From: Toshi Kani <toshi.kani@hpe.com>
To: Borislav Petkov <bp@suse.de>
Cc: jgross@suse.com, mcgrof@suse.com, x86@kernel.org,
linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com,
hpa@zytor.com, xen-devel@lists.xenproject.org,
tglx@linutronix.de, mingo@kernel.org, elliott@hpe.com
Subject: Re: [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface
Date: Wed, 23 Mar 2016 09:49:24 -0600 [thread overview]
Message-ID: <1458748164.6393.649.camel__19947.9200332009$1458745097$gmane$org@hpe.com> (raw)
In-Reply-To: <20160323085141.GC8031@pd.tnic>
On Wed, 2016-03-23 at 09:51 +0100, Borislav Petkov wrote:
> On Tue, Mar 22, 2016 at 03:40:45PM -0600, Toshi Kani wrote:
> > Will change to "Prevent the OS from initializing the PAT MSR".
> >
> > I wanted to clarify that "disable" does not mean to disable PAT MSR.
>
> How do you "disable PAT MSR" ?
We can't, but I thought not everyone knows how it works...
> I think you're overdocumenting this. pat_disable() is as clear as day
> what it does. It doesn't need any commenting...
Right, maybe I am just paranoid. I will remove the comment as you
suggested.
> > I've run checkpatch.pl and thought it was OK to have this warning
> > (instead of a >80 warning) since the error message part was not split.
> > The "attempting" part is for debugging and its string is passed from
> > the caller.
>
> We always put the quoted strings on a single line for easier grepping.
> Forget the 80-cols rule.
OK.
Thanks,
-Toshi
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-03-23 14:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 0:46 [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface Toshi Kani
2016-03-17 0:46 ` [PATCH v2 3/6] x86/mtrr: Fix Xorg crashes in Qemu sessions Toshi Kani
2016-03-17 0:46 ` [PATCH v2 4/6] x86/mtrr: Fix PAT init handling when MTRR MSR is disabled Toshi Kani
2016-03-17 0:46 ` [PATCH v2 5/6] x86/xen, pat: Remove PAT table init code from Xen Toshi Kani
2016-03-17 0:46 ` [PATCH v2 6/6] x86/pat: Document PAT initializations Toshi Kani
2016-03-22 16:59 ` [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface Borislav Petkov
[not found] ` <1458175619-32206-2-git-send-email-toshi.kani@hpe.com>
2016-03-22 17:00 ` [PATCH v2 3/6] x86/mtrr: Fix Xorg crashes in Qemu sessions Borislav Petkov
[not found] ` <20160322170047.GD5656@pd.tnic>
2016-03-22 21:53 ` Toshi Kani
[not found] ` <1458683610.6393.624.camel@hpe.com>
2016-03-23 8:44 ` Borislav Petkov
[not found] ` <20160323084437.GB8031@pd.tnic>
2016-03-23 15:53 ` Toshi Kani
[not found] ` <1458748393.6393.653.camel@hpe.com>
2016-03-23 21:47 ` Toshi Kani
[not found] ` <1458175619-32206-3-git-send-email-toshi.kani@hpe.com>
2016-03-22 17:01 ` [PATCH v2 4/6] x86/mtrr: Fix PAT init handling when MTRR MSR is disabled Borislav Petkov
[not found] ` <20160322170135.GE5656@pd.tnic>
2016-03-22 22:02 ` Toshi Kani
[not found] ` <1458175619-32206-4-git-send-email-toshi.kani@hpe.com>
2016-03-22 17:02 ` [PATCH v2 5/6] x86/xen, pat: Remove PAT table init code from Xen Borislav Petkov
[not found] ` <20160322170206.GF5656@pd.tnic>
2016-03-23 6:08 ` Juergen Gross
[not found] ` <1458175619-32206-5-git-send-email-toshi.kani@hpe.com>
2016-03-22 17:02 ` [PATCH v2 6/6] x86/pat: Document PAT initializations Borislav Petkov
[not found] ` <20160322170222.GG5656@pd.tnic>
2016-03-22 22:15 ` Toshi Kani
[not found] ` <20160322165944.GC5656@pd.tnic>
2016-03-22 21:40 ` [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface Toshi Kani
[not found] ` <1458682845.6393.614.camel@hpe.com>
2016-03-23 8:51 ` Borislav Petkov
[not found] ` <20160323085141.GC8031@pd.tnic>
2016-03-23 15:49 ` Toshi Kani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1458748164.6393.649.camel__19947.9200332009$1458745097$gmane$org@hpe.com' \
--to=toshi.kani@hpe.com \
--cc=bp@suse.de \
--cc=elliott@hpe.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).