From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 05/16] xen: sched: move pCPU initialization
	in an helper
Date: Thu, 24 Mar 2016 14:21:59 +0100
Message-ID: <1458825719.5082.37.camel@citrix.com>
References: <20160318185524.8117.74837.stgit@Solace.station>
 <20160318190432.8117.78163.stgit@Solace.station>
 <56F2D796.5010203@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3016400278396577797=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=884adae2e=dario.faggioli@citrix.com>)
 id 1aj5Dm-0002BO-KT
 for xen-devel@lists.xenproject.org; Thu, 24 Mar 2016 13:22:42 +0000
In-Reply-To: <56F2D796.5010203@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Juergen Gross <juergen.gross@ts.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

--===============3016400278396577797==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-spd1/+Z4iX4B9QlVI3Cn"

--=-spd1/+Z4iX4B9QlVI3Cn
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2016-03-23 at 17:51 +0000, George Dunlap wrote:
> On 18/03/16 19:04, Dario Faggioli wrote:
> > --- a/xen/common/sched_credit.c
> > +++ b/xen/common/sched_credit.c
> > @@ -542,16 +542,11 @@ csched_alloc_pdata(const struct scheduler
> > *ops, int cpu)
> > =C2=A0}
> > =C2=A0
> > =C2=A0static void
> > -csched_init_pdata(const struct scheduler *ops, void *pdata, int
> > cpu)
> > +init_pdata(struct csched_private *prv, struct csched_pcpu *spc,
> > int cpu)
> > =C2=A0{
> > -=C2=A0=C2=A0=C2=A0=C2=A0struct csched_private *prv =3D CSCHED_PRIV(ops=
);
> > -=C2=A0=C2=A0=C2=A0=C2=A0struct csched_pcpu * const spc =3D pdata;
> > -=C2=A0=C2=A0=C2=A0=C2=A0unsigned long flags;
> > -
> > -=C2=A0=C2=A0=C2=A0=C2=A0/* cpu data needs to be allocated, but STILL u=
ninitialized */
> > -=C2=A0=C2=A0=C2=A0=C2=A0ASSERT(spc && spc->runq.next =3D=3D spc->runq.=
prev && spc-
> > >runq.next =3D=3D NULL);
> > -
> > -=C2=A0=C2=A0=C2=A0=C2=A0spin_lock_irqsave(&prv->lock, flags);
> > +=C2=A0=C2=A0=C2=A0=C2=A0ASSERT(spin_is_locked(&prv->lock));
> > +=C2=A0=C2=A0=C2=A0=C2=A0/* cpu data needs to be allocated, but STILL u=
ninitialized. */
> > +=C2=A0=C2=A0=C2=A0=C2=A0ASSERT(spc && spc->runq.next =3D=3D NULL && sp=
c->runq.prev =3D=3D
> > NULL);
> Actually, Juergen, looks like Dario already agrees with us. ;-)
>=20
Indeed I do! :-)

> Obviously this should be updated in the previous patch instead.
>=20
Yeah, sorry. Rebasing / patch-splitting gone wrong! :-/

> With that done:
>=20
> Reviewed-by: George Dunlap <george.dunlap@citrix.com>
>=20
I'll do that.

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-spd1/+Z4iX4B9QlVI3Cn
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlbz6fcACgkQk4XaBE3IOsQLIgCfeiiZc+TMG+4DsZaIhFUCpYnD
S28AnRif1kHFD7/Eo42MygJDmzT69poz
=dXhY
-----END PGP SIGNATURE-----

--=-spd1/+Z4iX4B9QlVI3Cn--


--===============3016400278396577797==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============3016400278396577797==--