xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Shannon Zhao <shannon.zhao@linaro.org>
To: xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	peter.huangpeng@huawei.com, julien.grall@arm.com,
	stefano.stabellini@citrix.com, shannon.zhao@linaro.org,
	Jan Beulich <jbeulich@suse.com>,
	zhaoshenglong@huawei.com
Subject: [PATCH v7 21/22] xen/arm: Add a hypercall for device mmio mapping
Date: Fri, 25 Mar 2016 21:48:54 +0800	[thread overview]
Message-ID: <1458913735-2678-22-git-send-email-shannon.zhao@linaro.org> (raw)
In-Reply-To: <1458913735-2678-1-git-send-email-shannon.zhao@linaro.org>

It needs to map platform or amba device mmio to Dom0 on ARM. But when
booting with ACPI, it can't get the mmio region in Xen due to lack of
AML interpreter to parse DSDT table. Therefore, let Dom0 call a
hypercall to map mmio region when it adds the devices.

Here we add a new map space like the XEN_DOMCTL_memory_mapping to map
mmio region for Dom0.

Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>
Cc: Tim Deegan <tim@xen.org>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
---
 xen/arch/arm/mm.c           |  3 +++
 xen/arch/arm/p2m.c          | 22 ++++++++++++++++++++++
 xen/common/memory.c         | 16 ++++++++++++++++
 xen/include/asm-arm/p2m.h   |  5 +++++
 xen/include/public/memory.h |  1 +
 5 files changed, 47 insertions(+)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 81f9e2e..0aae6c5 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1138,6 +1138,9 @@ int xenmem_add_to_physmap_one(
         rcu_unlock_domain(od);
         break;
     }
+    case XENMAPSPACE_dev_mmio:
+        rc = map_dev_mmio_region(d, gpfn, 1, idx);
+        return rc;
 
     default:
         return -ENOSYS;
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 7e5f5d1..0011708 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -7,6 +7,7 @@
 #include <xen/bitops.h>
 #include <xen/vm_event.h>
 #include <xen/mem_access.h>
+#include <xen/iocap.h>
 #include <public/vm_event.h>
 #include <asm/flushtlb.h>
 #include <asm/gic.h>
@@ -1270,6 +1271,27 @@ int unmap_mmio_regions(struct domain *d,
                              d->arch.p2m.default_access);
 }
 
+int map_dev_mmio_region(struct domain *d,
+                        unsigned long start_gfn,
+                        unsigned long nr,
+                        unsigned long mfn)
+{
+    int res;
+
+    if ( !(nr && iomem_access_permitted(d, start_gfn, start_gfn + nr - 1)) )
+        return 0;
+
+    res = map_mmio_regions(d, start_gfn, nr, mfn);
+    if ( res < 0 )
+    {
+        printk(XENLOG_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
+               start_gfn, start_gfn + nr - 1, d->domain_id);
+        return res;
+    }
+
+    return 0;
+}
+
 int guest_physmap_add_entry(struct domain *d,
                             unsigned long gpfn,
                             unsigned long mfn,
diff --git a/xen/common/memory.c b/xen/common/memory.c
index c7fca96..25ff86c 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -980,6 +980,14 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
         if ( d == NULL )
             return -ESRCH;
 
+        /*
+         * XENMAPSPACE_dev_mmio mapping is only supported for hardware Domain
+         * to map this kind of space to itself.
+         */
+        if ( (xatp.space == XENMAPSPACE_dev_mmio) &&
+             ((d != current->domain) || !is_hardware_domain(d)) )
+            return -EACCES;
+
         rc = xsm_add_to_physmap(XSM_TARGET, current->domain, d);
         if ( rc )
         {
@@ -1024,6 +1032,14 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
         if ( d == NULL )
             return -ESRCH;
 
+        /*
+         * XENMAPSPACE_dev_mmio mapping is only supported for hardware Domain
+         * to map this kind of space to itself.
+         */
+        if ( (xatpb.space == XENMAPSPACE_dev_mmio) &&
+             ((d != current->domain) || !is_hardware_domain(d)) )
+            return -EACCES;
+
         rc = xsm_add_to_physmap(XSM_TARGET, current->domain, d);
         if ( rc )
         {
diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
index 55626b4..d240d1e 100644
--- a/xen/include/asm-arm/p2m.h
+++ b/xen/include/asm-arm/p2m.h
@@ -154,6 +154,11 @@ int unmap_regions_rw_cache(struct domain *d,
                            unsigned long nr_mfns,
                            unsigned long mfn);
 
+int map_dev_mmio_region(struct domain *d,
+                        unsigned long start_gfn,
+                        unsigned long nr,
+                        unsigned long mfn);
+
 int guest_physmap_add_entry(struct domain *d,
                             unsigned long gfn,
                             unsigned long mfn,
diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
index f69e92f..fe52ee1 100644
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -220,6 +220,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_machphys_mapping_t);
 #define XENMAPSPACE_gmfn_range   3 /* GMFN range, XENMEM_add_to_physmap only. */
 #define XENMAPSPACE_gmfn_foreign 4 /* GMFN from another dom,
                                     * XENMEM_add_to_physmap_batch only. */
+#define XENMAPSPACE_dev_mmio     5 /* device mmio region */
 /* ` } */
 
 /*
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-03-25 13:48 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25 13:48 [PATCH v7 00/22] Prepare UEFI and ACPI tables for Dom0 on ARM64 Shannon Zhao
2016-03-25 13:48 ` [PATCH v7 01/22] arm/acpi: Estimate memory required for acpi/efi tables Shannon Zhao
2016-03-26 13:02   ` Stefano Stabellini
2016-03-29 10:24   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 02/22] arm/acpi: Add a helper function to get the acpi table offset Shannon Zhao
2016-03-29 10:48   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 03/22] arm/acpi: Prepare FADT table for Dom0 Shannon Zhao
2016-03-25 13:48 ` [PATCH v7 04/22] arm/gic: Add a new callback for creating MADT " Shannon Zhao
2016-03-29 12:47   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 05/22] arm/acpi: Prepare " Shannon Zhao
2016-03-25 13:48 ` [PATCH v7 06/22] arm/acpi: Prepare STAO " Shannon Zhao
2016-03-25 13:48 ` [PATCH v7 07/22] arm/acpi: Prepare XSDT " Shannon Zhao
2016-03-25 13:48 ` [PATCH v7 08/22] arm/acpi: Prepare RSDP " Shannon Zhao
2016-03-25 13:48 ` [PATCH v7 09/22] arm/p2m: Add helper functions to map memory regions Shannon Zhao
2016-03-29 12:49   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 10/22] arm/acpi: Map all other tables for Dom0 Shannon Zhao
2016-03-29 13:02   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 11/22] arm/acpi: Prepare EFI system table " Shannon Zhao
2016-03-29 14:54   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 12/22] arm/acpi: Prepare EFI memory descriptor " Shannon Zhao
2016-03-29 14:54   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 13/22] arm/acpi: Map the new created EFI and ACPI tables to Dom0 Shannon Zhao
2016-03-29 15:01   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 14/22] arm/acpi: Create min DT stub for Dom0 Shannon Zhao
2016-03-29 16:10   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 15/22] arm/acpi: Permit access all Xen unused SPIs " Shannon Zhao
2016-03-29 16:10   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 16/22] arm/acpi: Configure SPI interrupt type and route to Dom0 dynamically Shannon Zhao
2016-03-29 16:12   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 17/22] arm/gic: Add a new callback to deny Dom0 access to GIC regions Shannon Zhao
2016-03-26 13:04   ` Stefano Stabellini
2016-03-29 16:13   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 18/22] arm/acpi: Permit MMIO access of Xen unused devices for Dom0 Shannon Zhao
2016-03-25 13:48 ` [PATCH v7 19/22] hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-03-29 16:16   ` Julien Grall
2016-03-25 13:48 ` [PATCH v7 20/22] xen/acpi: Fix event-channel interrupt when booting with ACPI Shannon Zhao
2016-03-29 16:16   ` Julien Grall
2016-03-25 13:48 ` Shannon Zhao [this message]
2016-03-30 16:05   ` [PATCH v7 21/22] xen/arm: Add a hypercall for device mmio mapping Konrad Rzeszutek Wilk
2016-03-30 16:07   ` Konrad Rzeszutek Wilk
2016-03-25 13:48 ` [PATCH v7 22/22] xen/arm64: Add ACPI support Shannon Zhao
2016-03-29 16:20   ` Julien Grall
2016-03-29  7:12 ` [PATCH v7 00/22] Prepare UEFI and ACPI tables for Dom0 on ARM64 Jan Beulich
2016-03-29 16:22   ` Julien Grall
2016-03-30  7:55     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458913735-2678-22-git-send-email-shannon.zhao@linaro.org \
    --to=shannon.zhao@linaro.org \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@arm.com \
    --cc=keir@xen.org \
    --cc=peter.huangpeng@huawei.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).