From: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
To: roger.pau@citrix.com, George.Dunlap@eu.citrix.com,
xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Paulina Szubarczyk <paulinaszubarczyk@gmail.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>
Subject: [PATCH 09/11] libxl: Remove pointless hypercall from libxl_set_memory_target
Date: Wed, 30 Mar 2016 17:02:48 +0200 [thread overview]
Message-ID: <1459350170-9573-10-git-send-email-paulinaszubarczyk@gmail.com> (raw)
In-Reply-To: <1459350170-9573-1-git-send-email-paulinaszubarczyk@gmail.com>
There's no obvious reason for the call to
xc_domain_getinfolist -- all it seems to be doing is checking that the domain
exists; but if it doesn't exist, it will have already failed by this point.
NB that this will change the return value for libxl_set_memory_target:
now it will return 0 on success, rather than returning 1 (which was
the previous behavior). This is more in line with expected behavior,
and also allows the caller to distingiush between success and other
failure modes (some of which also return 1).
Signed-off-by: George Dunlap <george.dunlap@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Dario Faggioli <dario.faggioli@citrix.com>
CC: Ian Campbell <ian.campbell@citrix.com>
---
tools/libxl/libxl.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index 93e228d..4291b57 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -4789,11 +4789,6 @@ retry_transaction:
libxl__xs_printf(gc, t, GCSPRINTF("%s/memory/target", dompath),
"%"PRIu32, new_target_memkb);
- rc = xc_domain_getinfolist(ctx->xch, domid, 1, &info);
- if (rc != 1 || info.domain != domid) {
- abort_transaction = 1;
- goto out;
- }
libxl_dominfo_init(&ptr);
xcinfo2xlinfo(ctx, &info, &ptr);
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-30 15:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:02 [PATCH 00/11] Return failure on failure for more xl commands Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 01/11] libxl_pci: improve return codes " Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 02/11] libxl_pci: clean an unused return variable Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 03/11] libxl_pci: Return error code for more pci-* functions Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 04/11] xl: improve return code for freemem function Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 05/11] xl: Make set_memory_target return an error code on failure Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 06/11] xl: Return an error on failed cd-insert Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 07/11] xl: Return error codes for pci* commands Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 08/11] xl: improve main_tmem_* return codes Paulina Szubarczyk
2016-03-30 15:02 ` Paulina Szubarczyk [this message]
2016-03-30 15:02 ` [PATCH 10/11] libxl: Fix libxl_set_memory_target return value Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 11/11] libxl: libxl_tmem functions improving coding style Paulina Szubarczyk
2016-03-30 15:14 ` [PATCH 00/11] Return failure on failure for more xl commands Wei Liu
2016-03-30 17:19 ` Paulina Szubarczyk
2016-03-31 15:06 ` Wei Liu
2016-04-01 9:55 ` Paulina Szubarczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459350170-9573-10-git-send-email-paulinaszubarczyk@gmail.com \
--to=paulinaszubarczyk@gmail.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).