From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH] xen: enable per-VCPU parameter for RTDS
Date: Tue, 5 Apr 2016 11:43:52 +0200
Message-ID: <1459849432.3166.30.camel@citrix.com>
References: <1459818433-2498-1-git-send-email-lichong659@gmail.com>
 <57038C1F02000078000E30A9@prv-mh.provo.novell.com>
 <57038472.3030407@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6261761617612155755=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <57038472.3030407@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: George Dunlap <george.dunlap@citrix.com>, Jan Beulich <JBeulich@suse.com>, Chong Li <lichong659@gmail.com>
Cc: george.dunlap@eu.citrix.com, Chong Li <chong.li@wustl.edu>, mengxu@cis.upenn.edu, dgolomb@seas.upenn.edu, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============6261761617612155755==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-to8xTVaClkusu1+m5jKv"

--=-to8xTVaClkusu1+m5jKv
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2016-04-05 at 10:25 +0100, George Dunlap wrote:
> On 05/04/16 08:57, Jan Beulich wrote:
> >=C2=A0
> > > Signed-off-by: Chong Li <chong.li@wustl.edu>
> > >=20
> > > Acked-by: Dario Faggioli <dario.faggioli@citrix.com>
> > This appears to be the 3rd variant of the patch, all with the same
> > bogus subject, and no versioning information at all. Please
> > remember that mails can arrive out of order, so there's no way
> > to reliably tell which one got sent first. So for this to go in I'm
> > expecting you to re-send with a proper subject and an indication
> > that this is not the initial version of the patch.
> And since this version of the patch is functionally different than
> the
> one Dario acked, you should drop his Acked-by as well.
>=20
Indeed you should have.

But, with the subject fixed (something like "xen: sched: fix deadlock
when changing scheduling parameters") and properly versioned, you can
add it again:

Acked-by: Dario Faggioli <dario.faggioli@citrix.com>

> Thanks for being responsive in fixing this bug; and sorry for all the
> criticism, but OSS development is very detail-oriented, and it takes
> a
> while to internalize all the rules for how things should be done.
>=20
It does! :-)

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-to8xTVaClkusu1+m5jKv
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlcDiNgACgkQk4XaBE3IOsQJIgCfQxWgWc4Aacjhd9ePU94JoI9V
INMAnRkoZp7/JWoHYFcHyXmChsmzG501
=23cJ
-----END PGP SIGNATURE-----

--=-to8xTVaClkusu1+m5jKv--


--===============6261761617612155755==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============6261761617612155755==--