From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [PATCH 6/6] libxl: log file name in failure in libxl__create_qemu_logfile
Date: Mon, 6 Jun 2016 11:52:12 +0100 [thread overview]
Message-ID: <1465210332-25440-7-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1465210332-25440-1-git-send-email-wei.liu2@citrix.com>
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
tools/libxl/libxl_dm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 155a653..69d2242 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -52,13 +52,15 @@ static int libxl__create_qemu_logfile(libxl__gc *gc, char *name)
if (rc) return rc;
logfile_w = open(logfile, O_WRONLY|O_CREAT|O_APPEND, 0644);
- free(logfile);
if (logfile_w < 0) {
- LOGE(ERROR, "unable to open Qemu logfile");
+ LOGE(ERROR, "unable to open Qemu logfile: %s", logfile);
+ free(logfile);
return ERROR_FAIL;
}
+ free(logfile);
+
return logfile_w;
}
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-06 10:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 10:52 [PATCH 0/6] xl/libxl: some cleanup / debugging aid patches Wei Liu
2016-06-06 10:52 ` [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary Wei Liu
2016-06-14 10:18 ` Ian Jackson
2016-06-14 10:23 ` Wei Liu
2016-06-14 14:15 ` Ian Jackson
2016-06-14 14:18 ` Wei Liu
2016-06-06 10:52 ` [PATCH 2/6] libxl: add emacs block to libxl_linux.c Wei Liu
2016-06-14 10:19 ` Ian Jackson
2016-06-06 10:52 ` [PATCH 3/6] libxl: linux hotplug: clean up get_hotplug_env Wei Liu
2016-06-14 10:20 ` Ian Jackson
2016-06-06 10:52 ` [PATCH 4/6] libxl: debug output for args and env when invoking hotplug script Wei Liu
2016-06-14 10:26 ` Ian Jackson
2016-06-14 12:46 ` Wei Liu
2016-07-02 10:21 ` Wei Liu
2016-07-04 17:06 ` Ian Jackson
2016-07-06 17:23 ` Wei Liu
2016-06-06 10:52 ` [PATCH 5/6] libxl: rename a field in libxl__domain_create_state Wei Liu
2016-06-14 10:27 ` Ian Jackson
2016-06-06 10:52 ` Wei Liu [this message]
2016-06-14 10:28 ` [PATCH 6/6] libxl: log file name in failure in libxl__create_qemu_logfile Ian Jackson
2016-06-14 13:10 ` [PATCH 0/6] xl/libxl: some cleanup / debugging aid patches Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465210332-25440-7-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).