On Wed, 2016-07-06 at 16:41 +0100, George Dunlap wrote:
> On Sat, Jun 18, 2016 at 12:11 AM, Dario Faggioli
> 
> > diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
> > index a38a63d..a6645a2 100644
> > --- a/xen/common/sched_credit.c
> > +++ b/xen/common/sched_credit.c
> > @@ -1819,24 +1819,24 @@ csched_schedule(
> >      else
> >          snext = csched_load_balance(prv, cpu, snext,
> > &ret.migrated);
> > 
> > + out:
> Sorry if I'm being a bit dense, but why is this moving up here?  As
> far as I can tell the only time the 'out' label will be used, the
> 'idler' status of the cpu cannot change.
> 
Mmm... I think you're right. If we go to out:, we are running someone
(so we are not idle), and we will continue to do so (so we should not
be marked as idle).

I seem to recall having seen something because of which out needed
bubbling up, but I don't any longer right now, so I'll leave it alone.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)