From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: JulienGrall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 1/4] xen/init: Annotate all command line parameter infrastructure as const
Date: Thu, 23 Jun 2016 17:08:19 +0100 [thread overview]
Message-ID: <183f6c1e-7f32-0c53-d843-0a33a4e6485e@citrix.com> (raw)
In-Reply-To: <576C23DB02000078000F83E2@prv-mh.provo.novell.com>
On 23/06/16 17:00, Jan Beulich wrote:
>>>> On 21.06.16 at 18:59, <andrew.cooper3@citrix.com> wrote:
>> --- a/xen/include/xen/init.h
>> +++ b/xen/include/xen/init.h
>> @@ -86,10 +86,11 @@ struct kernel_param {
>> void *var;
>> };
>>
>> -extern struct kernel_param __setup_start, __setup_end;
>> +extern const struct kernel_param __setup_start[], __setup_end[];
>>
>> -#define __setup_str static __initdata __attribute__((__aligned__(1))) char
>> -#define __kparam static __initsetup \
>> +#define __setup_str static const __initconstrel \
>> + __attribute__((__aligned__(1))) char
> This slipped my attention during review, but causes build failure
> with some gcc versions now: Why __initconstrel rather than
> __initconst?
Because this was previously __initconst and you reverted it for breaking
on older GCC. Message ID <56CB470E02000078000D4DBA@prv-mh.provo.novell.com>
I can't replicate any build failures with any GCC or clang combination
to hand. Are you able to find some solution which GCC is happy with?
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-23 16:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 16:59 [PATCH v2 1/4] xen/init: Annotate all command line parameter infrastructure as const Andrew Cooper
2016-06-21 16:59 ` [PATCH v2 2/4] arm/init: Move .init.proc.info into .init.data Andrew Cooper
2016-06-21 17:18 ` Konrad Rzeszutek Wilk
2016-06-23 11:44 ` Julien Grall
2016-06-21 16:59 ` [PATCH v2 3/4] xen/init: Move initcall infrastructure " Andrew Cooper
2016-06-21 17:19 ` Konrad Rzeszutek Wilk
2016-06-21 17:25 ` Andrew Cooper
2016-06-22 7:00 ` Jan Beulich
2016-06-23 10:12 ` [PATCH v3 " Andrew Cooper
2016-06-23 11:46 ` Julien Grall
2016-06-21 16:59 ` [PATCH v2 4/4] x86/boot: copy/clear sections more efficiently Andrew Cooper
2016-06-22 6:57 ` [PATCH v2 1/4] xen/init: Annotate all command line parameter infrastructure as const Jan Beulich
2016-06-23 11:42 ` Julien Grall
2016-06-23 16:00 ` Jan Beulich
2016-06-23 16:08 ` Andrew Cooper [this message]
2016-06-24 9:29 ` [PATCH] init: fix build with older gcc Jan Beulich
2016-06-24 9:32 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=183f6c1e-7f32-0c53-d843-0a33a4e6485e@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).