xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [Xen-devel] [PATCH 3/5] x86emul: drop CASE_SIMD_DOUBLE_FP()
Date: Fri, 20 Dec 2019 14:40:05 +0100	[thread overview]
Message-ID: <19f87ebc-f030-33fb-5b67-c1657bf921c1@suse.com> (raw)
In-Reply-To: <7f7a6ba3-7308-b079-2df1-f5b8501b3cc6@suse.com>

It's used only by CASE_SIMD_ALL_FP(), which can equally well be
implemented in terms of CASE_SIMD_{PACKED,SCALAR}_FP().

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -6010,21 +6010,18 @@ x86_emulate(
     CASE_SIMD_PACKED_INT(pfx, opc):          \
     case X86EMUL_OPC_VEX_66(pfx, opc)
 
-#define CASE_SIMD_SINGLE_FP(kind, pfx, opc)  \
-    case X86EMUL_OPC##kind(pfx, opc):        \
-    case X86EMUL_OPC##kind##_F3(pfx, opc)
-#define CASE_SIMD_DOUBLE_FP(kind, pfx, opc)  \
-    case X86EMUL_OPC##kind##_66(pfx, opc):   \
-    case X86EMUL_OPC##kind##_F2(pfx, opc)
 #define CASE_SIMD_ALL_FP(kind, pfx, opc)     \
-    CASE_SIMD_SINGLE_FP(kind, pfx, opc):     \
-    CASE_SIMD_DOUBLE_FP(kind, pfx, opc)
+    CASE_SIMD_PACKED_FP(kind, pfx, opc):     \
+    CASE_SIMD_SCALAR_FP(kind, pfx, opc)
 #define CASE_SIMD_PACKED_FP(kind, pfx, opc)  \
     case X86EMUL_OPC##kind(pfx, opc):        \
     case X86EMUL_OPC##kind##_66(pfx, opc)
 #define CASE_SIMD_SCALAR_FP(kind, pfx, opc)  \
     case X86EMUL_OPC##kind##_F3(pfx, opc):   \
     case X86EMUL_OPC##kind##_F2(pfx, opc)
+#define CASE_SIMD_SINGLE_FP(kind, pfx, opc)  \
+    case X86EMUL_OPC##kind(pfx, opc):        \
+    case X86EMUL_OPC##kind##_F3(pfx, opc)
 
     CASE_SIMD_SCALAR_FP(, 0x0f, 0x2b):     /* movnts{s,d} xmm,mem */
         host_and_vcpu_must_have(sse4a);


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-12-20 13:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-20 13:37 [Xen-devel] [PATCH 0/5] x86emul: allow suppressing FPU/MMX/SIMD insn emulation Jan Beulich
2019-12-20 13:39 ` [Xen-devel] [PATCH 1/5] x86emul: use CASE_SIMD_PACKED_INT() where possible Jan Beulich
2019-12-20 15:35   ` Andrew Cooper
2019-12-20 13:39 ` [Xen-devel] [PATCH 2/5] x86emul: introduce CASE_SIMD_PACKED_INT_VEX() Jan Beulich
2019-12-20 15:42   ` Andrew Cooper
2019-12-20 13:40 ` Jan Beulich [this message]
2019-12-20 15:48   ` [Xen-devel] [PATCH 3/5] x86emul: drop CASE_SIMD_DOUBLE_FP() Andrew Cooper
2019-12-20 13:40 ` [Xen-devel] [PATCH 4/5] x86emul: introduce CASE_SIMD_..._FP_VEX() Jan Beulich
2019-12-20 15:49   ` Andrew Cooper
2019-12-20 13:41 ` [Xen-devel] [PATCH 5/5] x86emul: disable FPU/MMX/SIMD insn emulation when !HVM Jan Beulich
2019-12-20 16:01   ` Andrew Cooper
2019-12-20 16:20     ` Jan Beulich
2020-04-02 22:18     ` Andrew Cooper
2020-04-03  7:52       ` Jan Beulich
2020-03-24 12:10   ` [Xen-devel] Ping: " Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19f87ebc-f030-33fb-5b67-c1657bf921c1@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).