From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Russell King <linux@arm.linux.org.uk>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
David Vrabel <david.vrabel@citrix.com>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/5] xen: avoid module usage in non-modular code
Date: Sat, 19 Mar 2016 20:23:21 -0400 [thread overview]
Message-ID: <20160320002321.GX23251__26888.3135206581$1458433600$gmane$org@windriver.com> (raw)
In-Reply-To: <1456099568-5154-1-git-send-email-paul.gortmaker@windriver.com>
[[PATCH v2 0/5] xen: avoid module usage in non-modular code] On 21/02/2016 (Sun 19:06) Paul Gortmaker wrote:
> This series of commits is a part of a larger project to ensure
> people don't reference modular support functions in non-modular
> code. Overall there was roughly 5k lines of dead code in the
> kernel due to this. So far we've fixed several areas, like tty,
> x86, net, ... and we continue to work on other areas.
Just wondering if this is still pending for this merge window; Stefano
had reviewed the two commits he wanted changed vs. v1 and this v2 was
sent approximately a month ago w/o any further change requests.
Thanks,
Paul.
--
>
> There are several reasons to not use module support for code that
> can never be built as a module, but the big ones are:
>
> (1) it is easy to accidentally write unused module_exit and remove code
> (2) it can be misleading when reading the source, thinking it can be
> modular when the Makefile and/or Kconfig prohibit it
> (3) it requires the include of the module.h header file which in turn
> includes nearly everything else.
> (4) it gets copied/replicated into other code and spreads like weeds.
>
> For the xen subsystem, there are just five commits:
>
> First, we get rid of "include <linux/module.h>" instances that are
> completely unnecessary.
>
> Then #2 and #3 and #5 are basically trivial remapping to the
> appropriate non-modular counterparts, meaning that there is no
> runtime change here either.
>
> The fourth hypervisor commit is similar, but also has removal of
> some dead code associated with the module_exit function that will
> never be called. So the runtime should be the same, but the object
> file will be different (reduced in size).
>
> Patches created on linux-next and build tested for x86-64 and ARM64
> allmodconfig.
>
> ---
>
> [v2: manually inline one-liners in #4; update probe vs init fcn names
> in #5 ; both suggestions by Stefano ; add Reviewed tags to #1, #2, #3.
> Redid build testing on x86-64 and ARM64 to test for typos etc. ]
>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: xen-devel@lists.xenproject.org
>
> Paul Gortmaker (5):
> xen: audit usages of module.h ; remove unnecessary instances
> drivers/xen: make [xen-]ballon explicitly non-modular
> drivers/xen: make xenbus_dev_[front/back]end explicitly non-modular
> drivers/xen: make sys-hypervisor.c explicitly non-modular
> drivers/xen: make platform-pci.c explicitly non-modular
>
> arch/arm/include/asm/xen/hypercall.h | 2 ++
> drivers/xen/balloon.c | 4 ----
> drivers/xen/events/events_2l.c | 1 -
> drivers/xen/events/events_base.c | 2 +-
> drivers/xen/events/events_fifo.c | 1 -
> drivers/xen/features.c | 2 +-
> drivers/xen/grant-table.c | 1 -
> drivers/xen/platform-pci.c | 16 ++++++----------
> drivers/xen/sys-hypervisor.c | 31 ++++---------------------------
> drivers/xen/xen-balloon.c | 14 +++-----------
> drivers/xen/xen-pciback/conf_space.c | 2 +-
> drivers/xen/xen-pciback/pciback_ops.c | 2 +-
> drivers/xen/xen-pciback/xenbus.c | 2 +-
> drivers/xen/xen-selfballoon.c | 1 -
> drivers/xen/xenbus/xenbus_dev_backend.c | 13 ++-----------
> drivers/xen/xenbus/xenbus_dev_frontend.c | 13 ++-----------
> drivers/xen/xenbus/xenbus_xs.c | 1 -
> drivers/xen/xenfs/xensyms.c | 1 -
> 18 files changed, 24 insertions(+), 85 deletions(-)
>
> --
> 2.6.1
> Paul Gortmaker (5):
> xen: audit usages of module.h ; remove unnecessary instances
> drivers/xen: make [xen-]ballon explicitly non-modular
> drivers/xen: make xenbus_dev_[front/back]end explicitly non-modular
> drivers/xen: make sys-hypervisor.c explicitly non-modular
> drivers/xen: make platform-pci.c explicitly non-modular
>
> arch/arm/include/asm/xen/hypercall.h | 2 ++
> drivers/xen/balloon.c | 4 ---
> drivers/xen/events/events_2l.c | 1 -
> drivers/xen/events/events_base.c | 2 +-
> drivers/xen/events/events_fifo.c | 1 -
> drivers/xen/features.c | 2 +-
> drivers/xen/grant-table.c | 1 -
> drivers/xen/platform-pci.c | 22 +++++-------
> drivers/xen/sys-hypervisor.c | 59 +++++---------------------------
> drivers/xen/xen-balloon.c | 14 ++------
> drivers/xen/xen-pciback/conf_space.c | 2 +-
> drivers/xen/xen-pciback/pciback_ops.c | 2 +-
> drivers/xen/xen-pciback/xenbus.c | 2 +-
> drivers/xen/xen-selfballoon.c | 1 -
> drivers/xen/xenbus/xenbus_dev_backend.c | 13 ++-----
> drivers/xen/xenbus/xenbus_dev_frontend.c | 13 ++-----
> drivers/xen/xenbus/xenbus_xs.c | 1 -
> drivers/xen/xenfs/xensyms.c | 1 -
> 18 files changed, 31 insertions(+), 112 deletions(-)
>
> --
> 2.6.1
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-20 0:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1456099568-5154-1-git-send-email-paul.gortmaker@windriver.com>
2016-02-22 0:06 ` [PATCH v2 1/5] xen: audit usages of module.h ; remove unnecessary instances Paul Gortmaker
2016-02-22 0:06 ` [PATCH v2 2/5] drivers/xen: make [xen-]ballon explicitly non-modular Paul Gortmaker
2016-02-22 0:06 ` [PATCH v2 3/5] drivers/xen: make xenbus_dev_[front/back]end " Paul Gortmaker
2016-02-22 0:06 ` [PATCH v2 4/5] drivers/xen: make sys-hypervisor.c " Paul Gortmaker
2016-02-22 0:06 ` [PATCH v2 5/5] drivers/xen: make platform-pci.c " Paul Gortmaker
[not found] ` <1456099568-5154-5-git-send-email-paul.gortmaker@windriver.com>
2016-02-22 11:25 ` [PATCH v2 4/5] drivers/xen: make sys-hypervisor.c " Stefano Stabellini
[not found] ` <1456099568-5154-6-git-send-email-paul.gortmaker@windriver.com>
2016-02-22 11:27 ` [PATCH v2 5/5] drivers/xen: make platform-pci.c " Stefano Stabellini
2016-03-20 0:23 ` Paul Gortmaker [this message]
[not found] ` <20160320002321.GX23251@windriver.com>
2016-03-21 15:17 ` [PATCH v2 0/5] xen: avoid module usage in non-modular code David Vrabel
2016-02-22 0:06 Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20160320002321.GX23251__26888.3135206581$1458433600$gmane$org@windriver.com' \
--to=paul.gortmaker@windriver.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).