From: Wei Liu <wei.liu2@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Chong Li <chong.li@wustl.edu>,
wei.liu2@citrix.com, Sisu Xi <xisisu@gmail.com>,
george.dunlap@eu.citrix.com, xen-devel@lists.xen.org,
Meng Xu <mengxu@cis.upenn.edu>, Chong Li <lichong659@gmail.com>,
dgolomb@seas.upenn.edu
Subject: Re: [PATCH v9 for Xen 4.7 4/4] xl: enable per-VCPU parameter for RTDS
Date: Fri, 1 Apr 2016 14:43:10 +0100 [thread overview]
Message-ID: <20160401134310.GB27636@citrix.com> (raw)
In-Reply-To: <1459516518.5082.254.camel@citrix.com>
On Fri, Apr 01, 2016 at 03:15:18PM +0200, Dario Faggioli wrote:
> On Thu, 2016-03-31 at 23:59 -0500, Chong Li wrote:
> > Change main_sched_rtds and related output functions to support
> > per-VCPU settings.
> >
> > Signed-off-by: Chong Li <chong.li@wustl.edu>
> > Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> > Signed-off-by: Sisu Xi <xisisu@gmail.com>
> >
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
> >
> This Acked-by, I'm should have been removed. In fact, Wei sai it was
> subject to me saying Acked-by or Reviewed-by myself to v8. I did not
> say anything like that, and in fact I asked for changes, and Wei said
> himself that, at least some of those were necessary.
>
> Now, you've addressed those comments, and I'm happy about how the patch
> is looking now, so:
>
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
>
> But I really think Wei (or Ian) should (re-)look and (re-)Ack.
>
I'm happy with this patch, too. So
Acked-by: Wei Liu <wei.liu2@citrix.com>
> I've found only a couple of style issues. I don't feel like blocking
> the series or asking to resend... perhaps they can be fixed during
> commit? Or I'm up for sending a cleanup patch myself (which would not
> introduce any functional change), as soon as this hit the repo.
>
IMHO a separate patch is better. Adjusting during committing in such
large patch is error prone, plus there is huge backlog to be applied at
the moment.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-01 13:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 4:59 [PATCH v9 for Xen 4.7 0/4] Enable per-VCPU parameter for RTDS Chong Li
2016-04-01 4:59 ` [PATCH v9 for Xen 4.7 1/4] xen: enable " Chong Li
2016-04-01 9:35 ` Jan Beulich
2016-04-01 12:37 ` Dario Faggioli
2016-04-04 15:14 ` [hypervisor deadlock] " Andrew Cooper
2016-04-04 15:58 ` Chong Li
2016-04-04 16:05 ` George Dunlap
2016-04-04 16:32 ` Dario Faggioli
2016-04-04 16:47 ` Wei Liu
2016-04-04 17:22 ` Chong Li
2016-04-01 4:59 ` [PATCH v9 for Xen 4.7 2/4] libxc: " Chong Li
2016-04-01 4:59 ` [PATCH v9 for Xen 4.7 3/4] libxl: " Chong Li
2016-04-01 12:53 ` Dario Faggioli
2016-04-01 13:40 ` Wei Liu
2016-04-06 14:32 ` Ian Jackson
2016-04-06 14:55 ` Ian Jackson
2016-04-06 15:04 ` Wei Liu
2016-04-06 15:22 ` Ian Jackson
2016-04-06 15:38 ` Ian Jackson
2016-04-06 16:36 ` Dario Faggioli
2016-04-06 16:41 ` Chong Li
2016-04-06 18:54 ` Andrew Cooper
2016-04-06 19:20 ` Chong Li
2016-04-06 19:23 ` Andrew Cooper
2016-04-06 19:30 ` Wei Liu
2016-04-06 19:41 ` Chong Li
2016-04-06 19:49 ` Wei Liu
2016-04-06 20:01 ` Dario Faggioli
2016-04-01 4:59 ` [PATCH v9 for Xen 4.7 4/4] xl: " Chong Li
2016-04-01 13:15 ` Dario Faggioli
2016-04-01 13:43 ` Wei Liu [this message]
2016-04-01 13:51 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401134310.GB27636@citrix.com \
--to=wei.liu2@citrix.com \
--cc=chong.li@wustl.edu \
--cc=dario.faggioli@citrix.com \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=lichong659@gmail.com \
--cc=mengxu@cis.upenn.edu \
--cc=xen-devel@lists.xen.org \
--cc=xisisu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).