From: Tejun Heo <tj@kernel.org>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen: xenbus: Remove create_workqueue
Date: Tue, 31 May 2016 13:29:48 -0400 [thread overview]
Message-ID: <20160531172948.GI29775__3362.15906213528$1464715892$gmane$org@mtj.duckdns.org> (raw)
In-Reply-To: <20160531165630.GA21779@Karyakshetra>
On Tue, May 31, 2016 at 10:26:30PM +0530, Bhaktipriya Shridhar wrote:
> System workqueues have been able to handle high level of concurrency
> for a long time now and there's no reason to use dedicated workqueues
> just to gain concurrency. Replace dedicated xenbus_frontend_wq with the
> use of system_wq.
>
> Unlike a dedicated per-cpu workqueue created with create_workqueue(),
> system_wq allows multiple work items to overlap executions even on
> the same CPU; however, a per-cpu workqueue doesn't have any CPU
> locality or global ordering guarantees unless the target CPU is
> explicitly specified and the increase of local concurrency shouldn't
> make any difference.
>
> In this case, there is only a single work item, increase of concurrency
> level by switching to system_wq should not make any difference.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next parent reply other threads:[~2016-05-31 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160531165630.GA21779@Karyakshetra>
2016-05-31 17:29 ` Tejun Heo [this message]
[not found] ` <20160531172948.GI29775@mtj.duckdns.org>
2016-06-28 16:47 ` [PATCH v2] xen: xenbus: Remove create_workqueue Bhaktipriya Shridhar
2016-06-29 12:50 ` David Vrabel
2016-05-31 16:56 Bhaktipriya Shridhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20160531172948.GI29775__3362.15906213528$1464715892$gmane$org@mtj.duckdns.org' \
--to=tj@kernel.org \
--cc=bhaktipriya96@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).