xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] Run autogen.sh
Date: Thu, 9 Jun 2016 15:10:29 +0100	[thread overview]
Message-ID: <20160609141029.GO28116@citrix.com> (raw)
In-Reply-To: <22361.26824.420273.101804@mariner.uk.xensource.com>

On Thu, Jun 09, 2016 at 02:02:00PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH] Run autogen.sh"):
> > On Thu, Jun 09, 2016 at 01:28:05PM +0100, Wei Liu wrote:
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > > ---
> > >  configure         | 18 +++++++++---------
> > >  docs/configure    | 18 +++++++++---------
> > >  stubdom/configure | 18 +++++++++---------
> > >  tools/configure   | 18 +++++++++---------
> > >  4 files changed, 36 insertions(+), 36 deletions(-)
> > 
> > I'm not sure if this requires review or ack. But I would rather err on
> > the safe side here.
> 
> Did we forget to run autogen.sh after some recent patch ?  Or is this
> of a different version ?
> 
> I think some explanation is required.
> 

You patch to open 4.8 didn't update output from autogen.sh.

Maybe running autogen.sh should become part of the branching checklist.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-06-09 14:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 12:28 [PATCH] Run autogen.sh Wei Liu
2016-06-09 12:34 ` Wei Liu
2016-06-09 13:02   ` Ian Jackson
2016-06-09 13:08     ` Andrew Cooper
2016-06-09 13:34       ` Olaf Hering
2016-06-09 14:19         ` Wei Liu
2016-06-09 15:45           ` Ian Jackson
2016-06-09 15:47             ` Wei Liu
2016-06-09 14:10     ` Wei Liu [this message]
2016-06-09 14:55       ` Ian Jackson
2016-06-09 15:00         ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160609141029.GO28116@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).