Re: [PATCH 1/1] tools/xsplice: cleanup unnecessary "j = ARRAY_SIZE(action_options); "

From: Wei Liu <wei.liu2@citrix.com>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: ross.lagerwall@citrix.com, ian.jackson@eu.citrix.com,
	wei.liu2@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/1] tools/xsplice: cleanup unnecessary "j = ARRAY_SIZE(action_options); "
Date: Thu, 9 Jun 2016 16:21:45 +0100	[thread overview]
Message-ID: <20160609152145.GA756@citrix.com> (raw)
In-Reply-To: <1464572762-12143-1-git-send-email-dongli.zhang@oracle.com>

On Mon, May 30, 2016 at 09:46:02AM +0800, Dongli Zhang wrote:
> Local variable "j" would be used only when "i == ARRAY_SIZE(main_options)"
> is true. Thus, it is not necessary to update "j" when "i ==
> ARRAY_SIZE(main_options)" is false.
> 
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
>  tools/misc/xen-xsplice.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/misc/xen-xsplice.c b/tools/misc/xen-xsplice.c
> index ddaa079..811dc57 100644
> --- a/tools/misc/xen-xsplice.c
> +++ b/tools/misc/xen-xsplice.c
> @@ -435,8 +435,7 @@ int main(int argc, char *argv[])
>                     "'xen-xsplice help'\n", argv[1]);
>              return 1;
>          }
> -    } else
> -        j = ARRAY_SIZE(action_options);
> +    }
>  

And of course since xsplice doesn't exist anymore, this patch won't
apply.

Dongli, can you resubmit this patch and update the subject line
accordingly?

You can of course keep Konrad's Review-by tag. I don't expect him to
object.

Wei.

>      xch = xc_interface_open(0,0,0);
>      if ( !xch )
> -- 
> 1.9.1
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel