From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config Date: Mon, 13 Jun 2016 19:21:53 +0100 Message-ID: <20160613182153.GC23146@citrix.com> References: <1465396126-27426-1-git-send-email-wei.liu2@citrix.com> <1465396126-27426-3-git-send-email-wei.liu2@citrix.com> <20160613173936.GG5666@perard.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCWUn-0005sK-PP for xen-devel@lists.xenproject.org; Mon, 13 Jun 2016 18:21:57 +0000 Content-Disposition: inline In-Reply-To: <20160613173936.GG5666@perard.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Anthony PERARD Cc: Xen-devel , Wei Liu , Ian Jackson List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBKdW4gMTMsIDIwMTYgYXQgMDY6Mzk6MzZQTSArMDEwMCwgQW50aG9ueSBQRVJBUkQg d3JvdGU6Cj4gT24gV2VkLCBKdW4gMDgsIDIwMTYgYXQgMDM6Mjg6NDVQTSArMDEwMCwgV2VpIExp dSB3cm90ZToKPiA+IC4uLiBiZWNhdXNlIHRoZSBhdmFpbGFibGUgdmNwdSBiaXRtYXAgY2FuIGNo YW5nZSBkdXJpbmcgZG9tYWluIGxpZmUgdGltZQo+ID4gZHVlIHRvIGNwdSBob3RwbHVnIGFuZCB1 bnBsdWcuCj4gPiAKPiA+IEZvciBRRU1VIHVwc3RyZWFtLCB3ZSBpbnRlcnJvZ2F0ZSBRRU1VIGZv ciB0aGUgbnVtYmVyIG9mIHZjcHVzLiBGb3IKPiA+IG90aGVycywgd2UgbG9vayBkaXJlY3RseSBp bnRvIHhlbnN0b3JlIGZvciBpbmZvcm1hdGlvbi4KPiAKPiBJIHRyaWVkIHRvIG1pZ3JhdGUgYSBn dWVzdCwgYW5kIGxpYnhsIGFib3J0IGluCj4gbGlieGxfcmV0cmlldmVfZG9tYWluX2NvbmZpZ3Vy YXRpb24gd2l0aGluIHRoZSBzd2l0Y2gKPiAoZGV2aWNlX21vZGVsX3ZlcnNpb24pLgo+IAo+IAo+ ID4gUmVwb3J0ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KPiA+IFNpZ25l ZC1vZmYtYnk6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+Cj4gPiAtLS0KPiA+ICB0b29s cy9saWJ4bC9saWJ4bC5jIHwgODcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgODcgaW5zZXJ0aW9ucygrKQo+ ID4gCj4gPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwvbGlieGwuYyBiL3Rvb2xzL2xpYnhsL2xp YnhsLmMKPiA+IGluZGV4IDAwNmI4M2YuLjAyNzA2YWIgMTAwNjQ0Cj4gPiAtLS0gYS90b29scy9s aWJ4bC9saWJ4bC5jCj4gPiArKysgYi90b29scy9saWJ4bC9saWJ4bC5jCj4gPiBAQCAtNzIyMiw2 ICs3MjIyLDUzIEBAIHZvaWQgbGlieGxfbWFjX2NvcHkobGlieGxfY3R4ICpjdHgsIGxpYnhsX21h YyAqZHN0LCBsaWJ4bF9tYWMgKnNyYykKPiA+ICAgICAgICAgICgqZHN0KVtpXSA9ICgqc3JjKVtp XTsKPiA+ICB9Cj4gPiAgCj4gPiArc3RhdGljIGludCBsaWJ4bF9fdXBkYXRlX2F2YWlsX3ZjcHVz X3FtcChsaWJ4bF9fZ2MgKmdjLCB1aW50MzJfdCBkb21pZCwKPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBtYXhfdmNwdXMsCj4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9iaXRtYXAgKm1hcCkK PiA+ICt7Cj4gPiArICAgIGludCByYzsKPiA+ICsKPiA+ICsgICAgLyogRm9yIFFFTVUgdXBzdHJl YW0gd2UgYWx3YXlzIG5lZWQgdG8gcmV0dXJuIHRoZSBudW1iZXIKPiA+ICsgICAgICogb2YgY3B1 cyBwcmVzZW50IHRvIFFFTVUgd2hldGhlciB0aGV5IGFyZSBvbmxpbmUgb3Igbm90Owo+ID4gKyAg ICAgKiBvdGhlcndpc2UgUUVNVSB3b24ndCBhY2NlcHQgdGhlIHNhdmVkIHN0YXRlLgo+ID4gKyAg ICAgKi8KPiA+ICsgICAgcmMgPSBsaWJ4bF9fcW1wX3F1ZXJ5X2NwdXMoZ2MsIGRvbWlkLCBtYXAp Owo+ID4gKyAgICBpZiAocmMpIHsKPiA+ICsgICAgICAgIExPRyhFUlJPUiwgImZhaWwgdG8gZ2V0 IG51bWJlciBvZiBjcHVzIGZvciBkb21haW4gJWQiLCBkb21pZCk7Cj4gPiArICAgICAgICBnb3Rv IG91dDsKPiA+ICsgICAgfQo+ID4gKwo+ID4gKyAgICByYyA9IDA7Cj4gCj4gVGhlIHZhbHVlIHNo b3VsZCBhbHJlYWR5IGJlIDAgYXQgdGhpcyBwb2ludC4KPiAKCkkgd291bGQgbGlrZSB0byBrZWVw IHRoaXMgYXMtaXMgYmVjYXVzZSB0aGlzIGlzIGFuIGlkaW9tIHRoYXQgaXMgc2FmZXIKYWdhaW5z dCBmdXJ0aGVyIG1vZGlmaWNhdGlvbiBvZiB0aGlzIGZ1bmN0aW9uLgoKPiA+ICtvdXQ6Cj4gPiAr ICAgIHJldHVybiByYzsKPiA+ICt9Cj4gPiArCj4gPiArc3RhdGljIGludCBsaWJ4bF9fdXBkYXRl X2F2YWlsX3ZjcHVzX3hlbnN0b3JlKGxpYnhsX19nYyAqZ2MsIHVpbnQzMl90IGRvbWlkLAo+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBp bnQgbWF4X3ZjcHVzLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBsaWJ4bF9iaXRtYXAgKm1hcCkKPiA+ICt7Cj4gPiArICAgIGludCByYzsKPiA+ICsg ICAgdW5zaWduZWQgaW50IGk7Cj4gPiArICAgIGNvbnN0IGNoYXIgKmRvbXBhdGg7Cj4gPiArCj4g PiArICAgIGRvbXBhdGggPSBsaWJ4bF9feHNfZ2V0X2RvbXBhdGgoZ2MsIGRvbWlkKTsKPiA+ICsg ICAgaWYgKCFkb21wYXRoKSB7Cj4gPiArICAgICAgICByYyA9IEVSUk9SX0ZBSUw7Cj4gPiArICAg ICAgICBnb3RvIG91dDsKPiA+ICsgICAgfQo+ID4gKwo+ID4gKyAgICBmb3IgKGkgPSAwOyBpIDwg bWF4X3ZjcHVzOyBpKyspIHsKPiA+ICsgICAgICAgIGNvbnN0IGNoYXIgKnBhdGggPSBHQ1NQUklO VEYoIiVzL2NwdS8ldS9hdmFpbGFiaWxpdHkiLCBkb21wYXRoLCBpKTsKPiA+ICsgICAgICAgIGNv bnN0IGNoYXIgKmNvbnRlbnQgPSBsaWJ4bF9feHNfcmVhZChnYywgWEJUX05VTEwsIHBhdGgpOwo+ ID4gKyAgICAgICAgaWYgKCFzdHJuY21wKGNvbnRlbnQsICJvbmxpbmUiLCBzdHJsZW4oIm9ubGlu ZSIpKSkKPiAKPiBJIGRvbid0IHRoaW5rIHN0cm5jbXAgaXMgdXNlZnVsbCBoZXJlIGFzIG9uZSBv ZiB0aGUgYXJndW1lbnQgaXMgYSBwbGFpbgo+IHN0cmluZy4gT25lIGNvdWxkIGp1c3QgdXNlIHN0 cmNtcD8KPiAKCkZpbmUgYnkgbWUgb2YgY291cnNlLgoKPiA+ICsgICAgICAgICAgICBsaWJ4bF9i aXRtYXBfc2V0KG1hcCwgaSk7Cj4gPiArICAgIH0KPiA+ICsKPiA+ICsgICAgcmMgPSAwOwo+ID4g K291dDoKPiA+ICsgICAgcmV0dXJuIHJjOwo+ID4gK30KPiA+ICsKPiA+ICBpbnQgbGlieGxfcmV0 cmlldmVfZG9tYWluX2NvbmZpZ3VyYXRpb24obGlieGxfY3R4ICpjdHgsIHVpbnQzMl90IGRvbWlk LAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9kb21h aW5fY29uZmlnICpkX2NvbmZpZykKPiA+ICB7Cj4gPiBAQCAtNzI3MCw2ICs3MzE3LDQ2IEBAIGlu dCBsaWJ4bF9yZXRyaWV2ZV9kb21haW5fY29uZmlndXJhdGlvbihsaWJ4bF9jdHggKmN0eCwgdWlu dDMyX3QgZG9taWQsCj4gPiAgICAgICAgICBsaWJ4bF9kb21pbmZvX2Rpc3Bvc2UoJmluZm8pOwo+ ID4gICAgICB9Cj4gPiAgCj4gPiArICAgIC8qIFZDUFVzICovCj4gPiArICAgIHsKPiA+ICsgICAg ICAgIGxpYnhsX2JpdG1hcCAqbWFwID0gJmRfY29uZmlnLT5iX2luZm8uYXZhaWxfdmNwdXM7Cj4g PiArICAgICAgICB1bnNpZ25lZCBpbnQgbWF4X3ZjcHVzID0gZF9jb25maWctPmJfaW5mby5tYXhf dmNwdXM7Cj4gPiArCj4gPiArICAgICAgICBsaWJ4bF9iaXRtYXBfZGlzcG9zZShtYXApOwo+ID4g KyAgICAgICAgbGlieGxfYml0bWFwX2luaXQobWFwKTsKPiA+ICsgICAgICAgIGxpYnhsX2JpdG1h cF9hbGxvYyhDVFgsIG1hcCwgbWF4X3ZjcHVzKTsKPiA+ICsgICAgICAgIGxpYnhsX2JpdG1hcF9z ZXRfbm9uZShtYXApOwo+ID4gKwo+ID4gKyAgICAgICAgc3dpdGNoIChkX2NvbmZpZy0+Yl9pbmZv LnR5cGUpIHsKPiA+ICsgICAgICAgIGNhc2UgTElCWExfRE9NQUlOX1RZUEVfSFZNOgo+ID4gKyAg ICAgICAgICAgIHN3aXRjaCAoZF9jb25maWctPmJfaW5mby5kZXZpY2VfbW9kZWxfdmVyc2lvbikg ewo+ID4gKyAgICAgICAgICAgIGNhc2UgTElCWExfREVWSUNFX01PREVMX1ZFUlNJT05fUUVNVV9Y RU46Cj4gPiArICAgICAgICAgICAgICAgIHJjID0gbGlieGxfX3VwZGF0ZV9hdmFpbF92Y3B1c19x bXAoZ2MsIGRvbWlkLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIG1heF92Y3B1cywgbWFwKTsKPiA+ICsgICAgICAgICAgICAgICAgYnJlYWs7 Cj4gPiArICAgICAgICAgICAgY2FzZSBMSUJYTF9ERVZJQ0VfTU9ERUxfVkVSU0lPTl9RRU1VX1hF Tl9UUkFESVRJT05BTDoKPiA+ICsgICAgICAgICAgICBjYXNlIExJQlhMX0RFVklDRV9NT0RFTF9W RVJTSU9OX05PTkU6Cj4gPiArICAgICAgICAgICAgICAgIHJjID0gbGlieGxfX3VwZGF0ZV9hdmFp bF92Y3B1c194ZW5zdG9yZShnYywgZG9taWQsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtYXhfdmNwdXMsIG1hcCk7Cj4gPiArICAg ICAgICAgICAgICAgIGJyZWFrOwo+ID4gKyAgICAgICAgICAgIGRlZmF1bHQ6Cj4gPiArICAgICAg ICAgICAgYWJvcnQoKTsKPiAKPiBNaXNzaW5nIGluZGVudGF0aW9uIGZvciBhYm9ydC4KPiAKCldp bGwgZml4LgoKPiBBbHNvLCB0aGF0IGlzIHdoZXJlIHhsIGFib3J0IG9uIG1pZ3JhdGlvbi4KPiAK CkhtbS4uLiAgVGhpcyBtZWFucyB0aGUgZGV2aWNlIG1vZGVsIHZlcnNpb24gaXMgbm90IHZhbGlk ICh1bmtub3duPykuCgpDYW4geW91IHBhc3RlIGluIHlvdXIgZ3Vlc3QgY29uZmlnPwoKV2VpLgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK