From: Wei Liu <wei.liu2@citrix.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH RFC 2/2] xen: make available hvm_fep to non-debug build as well
Date: Wed, 15 Jun 2016 15:47:03 +0100 [thread overview]
Message-ID: <20160615144703.GE28116@citrix.com> (raw)
In-Reply-To: <146f27e5-c8d1-b727-a40c-8f17fd873209@cardoe.com>
On Wed, Jun 15, 2016 at 09:39:24AM -0500, Doug Goldstein wrote:
> On 6/15/16 9:31 AM, Wei Liu wrote:
[...]
> > -#ifndef NDEBUG
> > /* Permit use of the Forced Emulation Prefix in HVM guests */
> > extern bool_t opt_hvm_fep;
> > -#else
> > -#define opt_hvm_fep 0
> > -#endif
>
> Please instead add this as a Kconfig option and you can default it to
> enabled.
>
Sure, it is reasonable that you want to compile this out.
But which section does it belong to? Architecture Features I guess?
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-15 14:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 14:31 [PATCH RFC 0/2] Make hvm_fep available to non-debug builds Wei Liu
2016-06-15 14:31 ` [PATCH RFC 1/2] xen/kernel: document 'C' in print_tainted Wei Liu
2016-06-15 14:53 ` Jan Beulich
2016-06-15 14:31 ` [PATCH RFC 2/2] xen: make available hvm_fep to non-debug build as well Wei Liu
2016-06-15 14:39 ` Doug Goldstein
2016-06-15 14:47 ` Wei Liu [this message]
2016-06-15 16:12 ` Doug Goldstein
2016-06-15 16:14 ` Wei Liu
2016-06-16 11:37 ` Jan Beulich
2016-06-16 11:52 ` Wei Liu
2016-06-16 12:12 ` Andrew Cooper
2016-06-16 12:20 ` Wei Liu
2016-06-16 12:31 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615144703.GE28116@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).