From: Wei Liu <wei.liu2@citrix.com>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: ross.lagerwall@citrix.com, ian.jackson@eu.citrix.com,
wei.liu2@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/1] tools/livepatch: initialise j to 0 to make some versions of gcc happy
Date: Thu, 16 Jun 2016 09:49:20 +0100 [thread overview]
Message-ID: <20160616084920.GI28116@citrix.com> (raw)
In-Reply-To: <1465996073-2739-1-git-send-email-dongli.zhang@oracle.com>
On Wed, Jun 15, 2016 at 09:07:53PM +0800, Dongli Zhang wrote:
> Initialise j to 0 to make some versions of gcc (e.g., gcc4.5/4.3) happy to
> avoid compilation error by commit beba3693f7243e68bbe31fe3794da91068eeea5b.
>
I suggest pasting in Olaf's exact error message here.
To avoid extra round trip, I propose updating the commit message as
followed:
Initialise j to 0 to make some versions of gcc (e.g., gcc4.5/4.3) happy to
avoid compilation error by commit beba3693f7243e68bbe31fe3794da91068eeea5b.
Failure manifests with gcc 4.5 as:
[ 153s] cc1: warnings being treated as errors
[ 153s] xen-livepatch.c: In function 'main':
[ 153s] xen-livepatch.c:415:12: error: 'j' may be used uninitialized in this function
[ 153s] make[3]: *** [xen-livepatch.o] Error 1
If you agree with this I will handle the updating while doing my next
sweep.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-16 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 13:07 [PATCH 1/1] tools/livepatch: initialise j to 0 to make some versions of gcc happy Dongli Zhang
2016-06-16 8:49 ` Wei Liu [this message]
2016-06-16 21:47 Dongli Zhang
2016-06-17 10:02 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616084920.GI28116@citrix.com \
--to=wei.liu2@citrix.com \
--cc=dongli.zhang@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=ross.lagerwall@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).