From: Wei Liu <wl@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Wei Liu" <liuwe@microsoft.com>, "Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Paul Durrant" <pdurrant@amazon.com>,
"Michael Kelley" <mikelley@microsoft.com>,
"Xen Development List" <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 1/4] x86/hyperv: misc cleanup
Date: Thu, 13 Feb 2020 12:24:56 +0000 [thread overview]
Message-ID: <20200213122456.ciobb2esg46hib7u@debian> (raw)
In-Reply-To: <628b1e12-527d-5457-b97d-09c3d530ebbb@suse.com>
On Thu, Feb 13, 2020 at 10:46:56AM +0100, Jan Beulich wrote:
> On 12.02.2020 17:09, Wei Liu wrote:
> > --- a/xen/arch/x86/guest/hyperv/private.h
> > +++ b/xen/arch/x86/guest/hyperv/private.h
> > @@ -26,6 +26,6 @@
> >
> > DECLARE_PER_CPU(void *, hv_input_page);
> > DECLARE_PER_CPU(void *, hv_vp_assist);
> > -DECLARE_PER_CPU(unsigned int, hv_vp_index);
> > +DECLARE_PER_CPU(uint32_t, hv_vp_index);
>
> You've got a co-maintainer ack, i.e. so be it, but FTR this is
> against what CodingStyle says, afaict: "Fixed width types should
> only be used when a fixed width quantity is meant (which for
> example may be a value read from or to be written to a register)."
> If you handed the address (perhaps indirectly, e.g. by converting
> to a physical one first) of this variable to Hyper-V, then things
> would be different. But
>
> this_cpu(hv_vp_index) = vp_index_msr;
>
> would, if unsigned int was wider than 32 bits, not cause any
Did you mean "wouldn't" here?
> issues. And this is the only place the variable currently gets
> accessed, and I expect future uses will just be reads of it (as
> can be seen later in the series).
>
Yes.
Wei.
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-13 12:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 16:09 [Xen-devel] [PATCH 0/4] Xen on Hyper-V: Implement L0 assisted TLB flush Wei Liu
2020-02-12 16:09 ` [Xen-devel] [PATCH 1/4] x86/hyperv: misc cleanup Wei Liu
2020-02-12 16:53 ` Roger Pau Monné
2020-02-13 10:30 ` Wei Liu
2020-02-13 8:43 ` Durrant, Paul
2020-02-13 9:46 ` Jan Beulich
2020-02-13 12:24 ` Wei Liu [this message]
2020-02-13 13:32 ` Jan Beulich
2020-02-12 16:09 ` [Xen-devel] [PATCH 2/4] x86/hypervisor: pass flags to hypervisor_flush_tlb Wei Liu
2020-02-12 17:00 ` Roger Pau Monné
2020-02-13 8:48 ` Durrant, Paul
2020-02-13 10:29 ` Wei Liu
2020-02-13 11:56 ` Wei Liu
2020-02-12 16:09 ` [Xen-devel] [PATCH 3/4] x86/hyperv: skeleton for L0 assisted TLB flush Wei Liu
2020-02-12 17:09 ` Roger Pau Monné
2020-02-12 23:01 ` Wei Liu
2020-02-12 16:09 ` [Xen-devel] [PATCH 4/4] x86/hyperv: " Wei Liu
2020-02-12 17:43 ` Roger Pau Monné
2020-02-13 9:49 ` Jan Beulich
2020-02-13 12:25 ` Wei Liu
2020-02-13 12:20 ` Wei Liu
2020-02-13 12:41 ` Roger Pau Monné
2020-02-14 10:47 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213122456.ciobb2esg46hib7u@debian \
--to=wl@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=liuwe@microsoft.com \
--cc=mikelley@microsoft.com \
--cc=pdurrant@amazon.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).