From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>,
Jun Nakajima <jun.nakajima@intel.com>, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: [Xen-devel] [PATCH 3/3] x86/nvmx: update exit bitmap on vmexit
Date: Fri, 20 Mar 2020 20:07:37 +0100 [thread overview]
Message-ID: <20200320190737.42110-4-roger.pau@citrix.com> (raw)
In-Reply-To: <20200320190737.42110-1-roger.pau@citrix.com>
Current code in nvmx_update_apicv set the guest interrupt status field
but doesn't update the exit bitmap, which can cause issues of lost
interrupts on the L1 hypervisor if vmx_intr_assist gets
short-circuited by nvmx_intr_intercept returning true.
Extract the code to update the exit bitmap from vmx_intr_assist into a
helper and use it in nvmx_update_apicv when updating the guest
interrupt status field.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
xen/arch/x86/hvm/vmx/intr.c | 21 +++++++++++++--------
xen/arch/x86/hvm/vmx/vvmx.c | 1 +
xen/include/asm-x86/hvm/vmx/vmx.h | 2 ++
3 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c
index 49a1295f09..000e14af49 100644
--- a/xen/arch/x86/hvm/vmx/intr.c
+++ b/xen/arch/x86/hvm/vmx/intr.c
@@ -224,6 +224,18 @@ static int nvmx_intr_intercept(struct vcpu *v, struct hvm_intack intack)
return 0;
}
+void vmx_sync_exit_bitmap(struct vcpu *v)
+{
+ const unsigned int n = ARRAY_SIZE(v->arch.hvm.vmx.eoi_exit_bitmap);
+ unsigned int i;
+
+ while ( (i = find_first_bit(&v->arch.hvm.vmx.eoi_exitmap_changed, n)) < n )
+ {
+ clear_bit(i, &v->arch.hvm.vmx.eoi_exitmap_changed);
+ __vmwrite(EOI_EXIT_BITMAP(i), v->arch.hvm.vmx.eoi_exit_bitmap[i]);
+ }
+}
+
void vmx_intr_assist(void)
{
struct hvm_intack intack;
@@ -318,7 +330,6 @@ void vmx_intr_assist(void)
intack.source != hvm_intsrc_vector )
{
unsigned long status;
- unsigned int i, n;
/*
* intack.vector is the highest priority vector. So we set eoi_exit_bitmap
@@ -379,13 +390,7 @@ void vmx_intr_assist(void)
intack.vector;
__vmwrite(GUEST_INTR_STATUS, status);
- n = ARRAY_SIZE(v->arch.hvm.vmx.eoi_exit_bitmap);
- while ( (i = find_first_bit(&v->arch.hvm.vmx.eoi_exitmap_changed,
- n)) < n )
- {
- clear_bit(i, &v->arch.hvm.vmx.eoi_exitmap_changed);
- __vmwrite(EOI_EXIT_BITMAP(i), v->arch.hvm.vmx.eoi_exit_bitmap[i]);
- }
+ vmx_sync_exit_bitmap(v);
pt_intr_post(v, intack);
}
diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c
index 180d01e385..e041ecc115 100644
--- a/xen/arch/x86/hvm/vmx/vvmx.c
+++ b/xen/arch/x86/hvm/vmx/vvmx.c
@@ -1414,6 +1414,7 @@ static void nvmx_update_apicv(struct vcpu *v)
status |= rvi & VMX_GUEST_INTR_STATUS_SUBFIELD_BITMASK;
__vmwrite(GUEST_INTR_STATUS, status);
+ vmx_sync_exit_bitmap(v);
}
}
diff --git a/xen/include/asm-x86/hvm/vmx/vmx.h b/xen/include/asm-x86/hvm/vmx/vmx.h
index b334e1ec94..111ccd7e61 100644
--- a/xen/include/asm-x86/hvm/vmx/vmx.h
+++ b/xen/include/asm-x86/hvm/vmx/vmx.h
@@ -610,6 +610,8 @@ void update_guest_eip(void);
void vmx_pi_per_cpu_init(unsigned int cpu);
void vmx_pi_desc_fixup(unsigned int cpu);
+void vmx_sync_exit_bitmap(struct vcpu *v);
+
#ifdef CONFIG_HVM
void vmx_pi_hooks_assign(struct domain *d);
void vmx_pi_hooks_deassign(struct domain *d);
--
2.25.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-03-20 19:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 19:07 [Xen-devel] [PATCH 0/3] x86/nvmx: attempt to fix interrupt injection Roger Pau Monne
2020-03-20 19:07 ` [Xen-devel] [PATCH 1/3] Revert "x86/vvmx: fix virtual interrupt injection when Ack on exit control is used" Roger Pau Monne
2020-03-23 8:09 ` Jan Beulich
2020-03-23 14:48 ` Roger Pau Monné
2020-03-24 5:41 ` Tian, Kevin
2020-03-24 8:10 ` Jan Beulich
2020-03-24 8:49 ` Tian, Kevin
2020-03-24 10:47 ` Roger Pau Monné
2020-03-24 11:00 ` Tian, Kevin
2020-03-20 19:07 ` [Xen-devel] [PATCH 2/3] x86/nvmx: clarify and fix usage of nvmx_update_apicv Roger Pau Monne
2020-03-24 6:03 ` Tian, Kevin
2020-03-24 9:50 ` Roger Pau Monné
2020-03-24 10:11 ` Tian, Kevin
2020-03-24 11:22 ` Roger Pau Monné
2020-03-24 11:33 ` Tian, Kevin
2020-03-24 12:18 ` Roger Pau Monné
2020-03-26 5:49 ` Tian, Kevin
2020-03-20 19:07 ` Roger Pau Monne [this message]
2020-03-24 6:22 ` [Xen-devel] [PATCH 3/3] x86/nvmx: update exit bitmap on vmexit Tian, Kevin
2020-03-24 9:59 ` Roger Pau Monné
2020-03-24 10:16 ` Tian, Kevin
2020-03-24 11:24 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320190737.42110-4-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).