From: Wei Liu <wl@xen.org>
To: "YOUNG, MICHAEL A." <m.a.young@durham.ac.uk>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Wei Liu" <wl@xen.org>
Subject: Re: [Xen-devel] [XEN PATCH] mismatch between pyxc_methods flags and PyObject definitions
Date: Mon, 23 Mar 2020 11:48:48 +0000 [thread overview]
Message-ID: <20200323114848.pegjk2lsmkqtegcf@debian> (raw)
In-Reply-To: <27a883ea723d5d123cb3a10d2a6092ad54a6171e.1584485918.git.m.a.young@durham.ac.uk>
On Tue, Mar 17, 2020 at 11:01:43PM +0000, YOUNG, MICHAEL A. wrote:
> pygrub in xen-4.13.0 with python 3.8.2 fails with the error
>
> Traceback (most recent call last):
> File "/usr/libexec/xen/bin/pygrub", line 21, in <module>
> import xen.lowlevel.xc
> SystemError: bad call flags
>
> This patch fixes mismatches in tools/python/xen/lowlevel/xc/xc.c
> between the flag bits defined in pyxc_methods and the parameters passed
> to the corresponding PyObject definitions.
>
> With this patch applied pygrub works as expected.
>
> Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
I briefly checked Python's documentation. This patch looks correctly to
me. FWIW:
Reviewed-by: Wei Liu <wl@xen.org>
I will wait for Marek's opinion.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-03-23 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 23:01 [Xen-devel] [XEN PATCH] mismatch between pyxc_methods flags and PyObject definitions YOUNG, MICHAEL A.
2020-03-23 11:48 ` Wei Liu [this message]
2020-03-24 2:32 ` Marek Marczykowski-Górecki
2020-03-28 11:19 ` Wei Liu
2020-03-30 14:05 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323114848.pegjk2lsmkqtegcf@debian \
--to=wl@xen.org \
--cc=ian.jackson@eu.citrix.com \
--cc=m.a.young@durham.ac.uk \
--cc=marmarek@invisiblethingslab.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).