xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Oleksandr Andrushchenko" <Oleksandr_Andrushchenko@epam.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH v3 4/6] vpci: restrict unhandled read/write operations for guests
Date: Tue, 14 Mar 2023 20:56:30 +0000	[thread overview]
Message-ID: <20230314205612.3703668-5-volodymyr_babchuk@epam.com> (raw)
In-Reply-To: <20230314205612.3703668-1-volodymyr_babchuk@epam.com>

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

A guest would be able to read and write those registers which are not
emulated and have no respective vPCI handlers, so it will be possible
for it to access the hardware directly.
In order to prevent a guest from reads and writes from/to the unhandled
registers make sure only hardware domain can access the hardware directly
and restrict guests from doing so.

Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

---

v3:
 - No changes

Older comments from another series:

Since v6:
- do not use is_hwdom parameter for vpci_{read|write}_hw and use
  current->domain internally
- update commit message
New in v6
Moved into another series
---
 xen/drivers/vpci/vpci.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index 5232f9605b..199ff55672 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -220,6 +220,10 @@ static uint32_t vpci_read_hw(pci_sbdf_t sbdf, unsigned int reg,
 {
     uint32_t data;
 
+    /* Guest domains are not allowed to read real hardware. */
+    if ( !is_hardware_domain(current->domain) )
+        return ~(uint32_t)0;
+
     switch ( size )
     {
     case 4:
@@ -260,9 +264,13 @@ static uint32_t vpci_read_hw(pci_sbdf_t sbdf, unsigned int reg,
     return data;
 }
 
-static void vpci_write_hw(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
-                          uint32_t data)
+static void vpci_write_hw(pci_sbdf_t sbdf, unsigned int reg,
+                          unsigned int size, uint32_t data)
 {
+    /* Guest domains are not allowed to write real hardware. */
+    if ( !is_hardware_domain(current->domain) )
+        return;
+
     switch ( size )
     {
     case 4:
-- 
2.39.2

  parent reply	other threads:[~2023-03-14 20:57 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 20:56 [PATCH v3 0/6] vpci: first series in preparation for vpci on ARM Volodymyr Babchuk
2023-03-14 20:56 ` [PATCH v3 1/6] xen: add reference counter support Volodymyr Babchuk
2023-03-16 13:54   ` Roger Pau Monné
2023-03-16 14:03     ` Jan Beulich
2023-03-16 16:21       ` Roger Pau Monné
2023-04-11 22:27     ` Volodymyr Babchuk
2023-04-12 10:12       ` Roger Pau Monné
2023-03-16 16:19   ` Roger Pau Monné
2023-03-16 16:32     ` Jan Beulich
2023-03-16 16:39       ` Roger Pau Monné
2023-03-16 16:43         ` Jan Beulich
2023-03-16 16:48           ` Roger Pau Monné
2023-03-16 16:56             ` Jan Beulich
2023-03-17 10:05               ` Roger Pau Monné
2023-03-17 14:46                 ` Jan Beulich
2023-03-16 17:01   ` Jan Beulich
2023-04-11 22:38     ` Volodymyr Babchuk
2023-04-17  6:47       ` Jan Beulich
2023-03-14 20:56 ` [PATCH v3 2/6] xen: pci: introduce reference counting for pdev Volodymyr Babchuk
2023-03-16 16:16   ` Roger Pau Monné
2023-03-29  9:55     ` Jan Beulich
2023-03-29 10:48       ` Roger Pau Monné
2023-03-29 11:58         ` Jan Beulich
2023-04-11 23:41     ` Volodymyr Babchuk
2023-04-12  9:13       ` Roger Pau Monné
2023-04-12 21:54         ` Volodymyr Babchuk
2023-04-13 15:00           ` Roger Pau Monné
2023-04-14  1:30             ` Volodymyr Babchuk
2023-04-17 10:17               ` Roger Pau Monné
2023-04-17 10:34                 ` Jan Beulich
2023-04-17 10:51                   ` Roger Pau Monné
2023-04-17 11:02                     ` Jan Beulich
2023-04-21 11:00                     ` Volodymyr Babchuk
2023-04-21 12:24                       ` Jan Beulich
2023-04-21 13:02                         ` Volodymyr Babchuk
2023-04-21 13:10                       ` Roger Pau Monné
2023-04-21 14:13                         ` Volodymyr Babchuk
2023-04-24  7:46                           ` Jan Beulich
2023-04-24 14:15                             ` Volodymyr Babchuk
2023-04-24 14:27                               ` Jan Beulich
2023-03-29 10:04   ` Jan Beulich
2023-03-14 20:56 ` [PATCH v3 3/6] vpci: crash domain if we wasn't able to (un) map vPCI regions Volodymyr Babchuk
2023-03-16 16:32   ` Roger Pau Monné
2023-03-14 20:56 ` [PATCH v3 6/6] xen: pci: print reference counter when dumping pci_devs Volodymyr Babchuk
2023-03-17  8:46   ` Roger Pau Monné
2023-03-14 20:56 ` [PATCH v3 5/6] vpci: use reference counter to protect vpci state Volodymyr Babchuk
2023-03-17  8:43   ` Roger Pau Monné
2023-03-29  9:31     ` Jan Beulich
2023-03-14 20:56 ` Volodymyr Babchuk [this message]
2023-03-17  8:37   ` [PATCH v3 4/6] vpci: restrict unhandled read/write operations for guests Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230314205612.3703668-5-volodymyr_babchuk@epam.com \
    --to=volodymyr_babchuk@epam.com \
    --cc=Oleksandr_Andrushchenko@epam.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).