xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	"Changlong Xie" <xiecl.fnst@cn.fujitsu.com>,
	"Wen Congyang" <wency@cn.fujitsu.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 1/3] libxl: colo: rearrange things in header files
Date: Wed, 6 Apr 2016 14:41:19 +0100	[thread overview]
Message-ID: <22277.4607.468521.759471@mariner.uk.xensource.com> (raw)
In-Reply-To: <1459886762-8815-2-git-send-email-wei.liu2@citrix.com>

Wei Liu writes ("[PATCH 1/3] libxl: colo: rearrange things in header files"):
> We need to separate COLO code from common code as clean as possible.
> With this patch, all COLO structures are now in libxl_colo.h.
> 
> It does the following:
> 1. Move two typedefs for libxl__domain_create_state{,cb} back to
>    libxl_internal.h.
> 2. Move libxl__colo_save_state to libxl_colo.h.
> 3. Include libxl_internal.h in libxl_colo.h.
> 4. Move a bunch of colo typedefs to the top of libxl_internal.h.
> 5. Move the inclusion of libxl_colo.h to the right place in
>    libxl_internal.h.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

On the basis that I believe you that this is just code motion.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-06 13:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 20:05 [PATCH 0/3] COLO: only build on Linux Wei Liu
2016-04-05 20:06 ` [PATCH 1/3] libxl: colo: rearrange things in header files Wei Liu
2016-04-06 13:41   ` Ian Jackson [this message]
2016-04-05 20:06 ` [PATCH 2/3] libxl: colo: move netlink related stuff to libxl_colo_proxy.c Wei Liu
2016-04-06 13:41   ` Ian Jackson
2016-04-05 20:06 ` [PATCH 3/3] libxl: colo: only build COLO on Linux Wei Liu
2016-04-06 10:24   ` Wei Liu
2016-04-06  1:24 ` [PATCH 0/3] COLO: only build " Wen Congyang
2016-04-06 10:17   ` Wei Liu
2016-04-06 10:20     ` Wen Congyang
2016-04-06 10:22       ` Wei Liu
2016-04-06  6:19 ` Changlong Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22277.4607.468521.759471@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=wency@cn.fujitsu.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xiecl.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).