From: Ian Jackson <ian.jackson@citrix.com>
To: Paul Durrant <paul@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Paul Durrant <pdurrant@amazon.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore
Date: Tue, 4 Aug 2020 12:13:48 +0100 [thread overview]
Message-ID: <24361.17132.762055.478992@mariner.uk.xensource.com> (raw)
In-Reply-To: <20200803124931.2678-5-paul@xen.org>
Paul Durrant writes ("[PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore"):
> From: Paul Durrant <pdurrant@amazon.com>
>
> set_mtu() currently sets the backend vif MTU but does not inform the frontend
> what it is. This patch adds code to write the MTU into a xenstore node. See
> netif.h for a specification of the node.
>
> NOTE: There is also a small modification replacing '$mtu' with '${mtu}'
> for style consistency.
>
> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Reviewed-by: Ian Jackson <ian.jackson@eu.citrix.com>
> diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh
> index 37e71cfa9c..24fc42d9cf 100644
> --- a/tools/hotplug/Linux/xen-network-common.sh
> +++ b/tools/hotplug/Linux/xen-network-common.sh
> @@ -164,9 +164,21 @@ remove_from_bridge () {
> set_mtu () {
> local bridge=$1
> local dev=$2
> + local type_if=$3
> +
> mtu="`ip link show dev ${bridge}| awk '/mtu/ { print $5 }'`"
> if [ -n "$mtu" ] && [ "$mtu" -gt 0 ]
> then
> - ip link set dev ${dev} mtu $mtu || :
> + ip link set dev ${dev} mtu ${mtu} || :
> + fi
> +
> + if [ ${type_if} = vif ]
> + then
> + dev_=${dev#vif}
> + domid=${dev_%.*}
> + devid=${dev_#*.}
> +
> + XENBUS_PATH="/local/domain/$domid/device/vif/$devid"
> + xenstore_write "$XENBUS_PATH/mtu" ${mtu}
It's surprising to me that this code doesn't have the xenbus path
already in some variable. But I guess from the fact that you've added
this code, that it doesn't.
Ian.
next prev parent reply other threads:[~2020-08-04 11:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 12:49 [PATCH v2 0/4] tools: propagate bridge MTU to vif frontends Paul Durrant
2020-08-03 12:49 ` [PATCH v2 1/4] tools/hotplug: add remove_from_bridge() and improve debug output Paul Durrant
2020-08-04 11:06 ` Ian Jackson
2020-08-03 12:49 ` [PATCH v2 2/4] tools/hotplug: combine add/online and remove/offline in vif-bridge Paul Durrant
2020-08-04 11:08 ` Ian Jackson
2020-08-03 12:49 ` [PATCH v2 3/4] public/io/netif: specify MTU override node Paul Durrant
2020-08-04 11:10 ` Ian Jackson
2020-08-03 12:49 ` [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore Paul Durrant
2020-08-04 11:13 ` Ian Jackson [this message]
2020-08-04 11:20 ` Paul Durrant
2020-08-04 11:35 ` Ian Jackson
2020-08-04 13:31 ` Paul Durrant
2020-08-05 9:30 ` Ian Jackson
2020-08-05 9:44 ` Durrant, Paul
2020-08-05 10:13 ` Ian Jackson
2020-08-05 10:42 ` Durrant, Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24361.17132.762055.478992@mariner.uk.xensource.com \
--to=ian.jackson@citrix.com \
--cc=paul@xen.org \
--cc=pdurrant@amazon.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).