From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA735C4742C for ; Wed, 11 Nov 2020 08:16:38 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1911D206CA for ; Wed, 11 Nov 2020 08:16:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="c1qX3CpM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1911D206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.24350.51535 (Exim 4.92) (envelope-from ) id 1kclIk-0001co-Jp; Wed, 11 Nov 2020 08:16:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 24350.51535; Wed, 11 Nov 2020 08:16:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kclIk-0001ch-Fb; Wed, 11 Nov 2020 08:16:22 +0000 Received: by outflank-mailman (input) for mailman id 24350; Wed, 11 Nov 2020 08:16:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kclIj-0001cc-HM for xen-devel@lists.xenproject.org; Wed, 11 Nov 2020 08:16:21 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 718587b1-4f72-4325-b1d1-ce623a635394; Wed, 11 Nov 2020 08:16:20 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C45E8AC75; Wed, 11 Nov 2020 08:16:19 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kclIj-0001cc-HM for xen-devel@lists.xenproject.org; Wed, 11 Nov 2020 08:16:21 +0000 X-Inumbo-ID: 718587b1-4f72-4325-b1d1-ce623a635394 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 718587b1-4f72-4325-b1d1-ce623a635394; Wed, 11 Nov 2020 08:16:20 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1605082579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F0UVQ7XfQ1QsHhWC89QH2H73gajMtQD6fWVY+G9oIhg=; b=c1qX3CpMxMfJ+Kem2oOiaIpbOac7ZOl3HiFq1pF6nd1R1TFqX+AeCK5NJlxBmXIyai3gKj QJGA2wvyUwgeKMWSikvW5BWoVtI83YpQKBW5bY7kp4xac++v3YYq9IYFDVnDzktFuO2vgR YTOp+wslXaFu8tUGnT+C4FN/YmkWVGA= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C45E8AC75; Wed, 11 Nov 2020 08:16:19 +0000 (UTC) Subject: Re: [PATCH V2 04/23] xen/ioreq: Provide alias for the handle_mmio() To: Oleksandr Cc: xen-devel@lists.xenproject.org, 'Oleksandr Tyshchenko' , 'Andrew Cooper' , =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= , 'Wei Liu' , 'Julien Grall' , 'Stefano Stabellini' , 'Julien Grall' , paul@xen.org References: <1602780274-29141-1-git-send-email-olekstysh@gmail.com> <1602780274-29141-5-git-send-email-olekstysh@gmail.com> <004701d6a6c1$6c09f860$441de920$@xen.org> <38ba45dd-f1cd-a289-3ea3-75148782e126@suse.com> <004a01d6a6cd$1f4684b0$5dd38e10$@xen.org> <35d38051-129e-333d-ec94-aa36e68a3814@gmail.com> From: Jan Beulich Message-ID: <2e677d01-bf2f-e569-95a2-490dc05102d9@suse.com> Date: Wed, 11 Nov 2020 09:16:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: <35d38051-129e-333d-ec94-aa36e68a3814@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11.11.2020 09:09, Oleksandr wrote: > > On 11.11.20 09:27, Jan Beulich wrote: > > Hi Jan > >> On 10.11.2020 20:44, Oleksandr wrote: >>> On 20.10.20 13:38, Paul Durrant wrote: >>> >>> Hi Jan, Paul >>> >>> Sorry for the late response. >>> >>>>> -----Original Message----- >>>>> From: Jan Beulich >>>>> Sent: 20 October 2020 11:05 >>>>> To: paul@xen.org >>>>> Cc: 'Oleksandr Tyshchenko' ; xen-devel@lists.xenproject.org; 'Oleksandr >>>>> Tyshchenko' ; 'Andrew Cooper' ; 'Roger Pau >>>>> Monné' ; 'Wei Liu' ; 'Julien Grall' ; 'Stefano >>>>> Stabellini' ; 'Julien Grall' >>>>> Subject: Re: [PATCH V2 04/23] xen/ioreq: Provide alias for the handle_mmio() >>>>> >>>>> On 20.10.2020 11:14, Paul Durrant wrote: >>>>>>> From: Xen-devel On Behalf Of Oleksandr Tyshchenko >>>>>>> Sent: 15 October 2020 17:44 >>>>>>> >>>>>>> --- a/xen/include/asm-x86/hvm/ioreq.h >>>>>>> +++ b/xen/include/asm-x86/hvm/ioreq.h >>>>>>> @@ -181,6 +181,8 @@ static inline bool arch_hvm_ioreq_destroy(struct domain *d) >>>>>>> #define IOREQ_STATUS_UNHANDLED X86EMUL_UNHANDLEABLE >>>>>>> #define IOREQ_STATUS_RETRY X86EMUL_RETRY >>>>>>> >>>>>>> +#define ioreq_complete_mmio handle_mmio >>>>>>> + >>>>>> A #define? Really? Can we not have a static inline? >>>>> I guess this would require further shuffling: handle_mmio() is >>>>> an inline function in hvm/emulate.h, and hvm/ioreq.h has no >>>>> need to include the former (and imo it also shouldn't have). >>>>> >>>> I see. I think we need an x86 ioreq.c anyway, to deal with the legacy use of magic pages, so it could be dealt with there instead. >>> I am afraid I don't entirely understand the required changes. Could you >>> please clarify where the "inline(?)" ioreq_complete_mmio() should >>> live? I included hvm/emulate.h here not for the "handle_mmio()" reason >>> only, but for "struct hvm_emulate_ctxt" also (see arch_io_completion()). >> I'm sorry, but in the context of this patch there's no use of any >> struct hvm_emulate_ctxt instance. I'm not going to wade through 23 >> patches to find what you mean. > > Sorry for not being precise here. I meant arch_io_completion() added at [1] At least some of the inlines you add there are way too large to be inline functions, imo. But consensus appears to be now to retain a per-arch ioreq.c anyway. Jan > [1] > https://patchwork.kernel.org/project/xen-devel/patch/1602780274-29141-2-git-send-email-olekstysh@gmail.com/ >