From: Anastasiia Lukianenko <Anastasiia_Lukianenko@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Artem Mygaiev <Artem_Mygaiev@epam.com>,
"committers@xenproject.org" <committers@xenproject.org>,
"julien@xen.org" <julien@xen.org>,
"vicooodin@gmail.com" <vicooodin@gmail.com>,
"viktor.mitin.19@gmail.com" <viktor.mitin.19@gmail.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Xen Coding style and clang-format
Date: Wed, 30 Sep 2020 09:18:55 +0000 [thread overview]
Message-ID: <300923eb27aea4d19bff3c21bc51d749c315f8e3.camel@epam.com> (raw)
Hi all,
I would like to bring up a discussion about a Xen-checker tool, the
development of which has been temporarily suspended. The idea of this
tool is to use the clang-format approach as a base for Xen ‘checkpatch’
process. The new tool consists of modified clang-format binary and
modified clang-format-diff.py python script to automate Xen patches
format checking and reformatting. The tool can be used as a pre-commit
hook to check and format every patch automatically.
Xen checker is currently in a state of testing, but there are
controversial points regarding the coding style that I would like to
discuss with the community and make a unanimous decision on the
correctness of the formatting.
I would like to know your opinion on the following coding style cases.
Which option do you think is correct?
1) Function prototype when the string length is longer than the allowed
one
-static int __init
-acpi_parse_gic_cpu_interface(struct acpi_subtable_header *header,
- const unsigned long end)
+static int __init acpi_parse_gic_cpu_interface(
+ struct acpi_subtable_header *header, const unsigned long end)
2) Wrapping an operator to a new line when the length of the line is
longer than the allowed one
- if ( table->revision > 6
- || (table->revision == 6 && fadt->minor_revision >= 0) )
+ if ( table->revision > 6 ||
+ (table->revision == 6 && fadt->minor_revision >= 0) )
3) define code style
-#define ALLREGS \
- C(r0,r0_usr); C(r1,r1_usr); C(r2,r2_usr); C(r3,r3_usr); \
- C(cpsr,cpsr)
+#define ALLREGS \
+ C(r0, r0_usr); \
+ C(r1, r1_usr); \
+ C(r2, r2_usr); \
4) Comment style
- /* PC should be always a multiple of 4, as Xen is using ARM
instruction set */
+ /* PC should be always a multiple of 4, as Xen is using ARM
instruction set
+ */
Please find below the repo created by Viktor Mitin with xen clang-
format under the next link (branch xen-clang-format):
https://github.com/xen-troops/llvm-project/tree/xen-clang-format
The next script can be used as an example of how to build clang-format:
https://github.com/viktor-mitin/xen-clang-format-example/blob/master/build_clang_format.sh
Regards,
Anastasiia Lukianenko
next reply other threads:[~2020-09-30 9:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 9:18 Anastasiia Lukianenko [this message]
2020-09-30 9:57 ` Xen Coding style and clang-format Jan Beulich
2020-09-30 10:24 ` George Dunlap
2020-10-01 9:06 ` Anastasiia Lukianenko
2020-10-01 10:06 ` George Dunlap
2020-10-07 10:19 ` Anastasiia Lukianenko
2020-10-08 1:07 ` Stefano Stabellini
2020-10-12 14:37 ` Anastasiia Lukianenko
2020-10-12 18:09 ` George Dunlap
2020-10-13 12:30 ` Jan Beulich
2020-10-16 9:42 ` Anastasiia Lukianenko
2020-10-16 10:23 ` Julien Grall
2020-10-16 11:37 ` Artem Mygaiev
2020-10-19 18:07 ` Stefano Stabellini
2020-10-20 17:13 ` Julien Grall
2020-10-23 9:39 ` Anastasiia Lukianenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=300923eb27aea4d19bff3c21bc51d749c315f8e3.camel@epam.com \
--to=anastasiia_lukianenko@epam.com \
--cc=Artem_Mygaiev@epam.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=committers@xenproject.org \
--cc=julien@xen.org \
--cc=vicooodin@gmail.com \
--cc=viktor.mitin.19@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).