From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: "jgross@suse.com" <jgross@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
"dfaggioli@suse.com" <dfaggioli@suse.com>
Subject: Re: [RFC PATCH v1 3/6] sched, credit2: improve scheduler fairness
Date: Fri, 12 Jun 2020 11:38:25 +0000 [thread overview]
Message-ID: <33db319c8a533fc08b168d24c329533516d14f8b.camel@epam.com> (raw)
In-Reply-To: <bb7c8689-d247-0d28-088b-4774ebcdc345@suse.com>
On Fri, 2020-06-12 at 06:51 +0200, Jürgen Groß wrote:
> On 12.06.20 02:22, Volodymyr Babchuk wrote:
> > Now we can make corrections for scheduling unit run time, based on
> > data gathered in previous patches. This includes time spent in IRQ
> > handlers and time spent for hypervisor housekeeping tasks. Those time
> > spans needs to be deduced from a total run time.
> >
> > This patch adds sched_get_time_correction() function which returns
> > time correction value. This value should be subtracted by a scheduler
> > implementation from a total vCPU/shced_unit run time.
> >
> > TODO: Make the corresponding changes to all other schedulers.
> >
> > Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> > ---
> > xen/common/sched/core.c | 23 +++++++++++++++++++++++
> > xen/common/sched/credit2.c | 2 +-
> > xen/common/sched/private.h | 10 ++++++++++
> > 3 files changed, 34 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> > index d597811fef..a7294ff5c3 100644
> > --- a/xen/common/sched/core.c
> > +++ b/xen/common/sched/core.c
> > @@ -974,6 +974,29 @@ void vcpu_end_hyp_task(struct vcpu *v)
> > #ifndef NDEBUG
> > v->in_hyp_task = false;
> > #endif
> > +
> > +s_time_t sched_get_time_correction(struct sched_unit *u)
> > +{
> > + unsigned long flags;
> > + int irq, hyp;
>
> Using "irq" for a time value is misleading IMO.
Yes, you are right. I'll rename this variables to irq_time and
hyp_time.
> > +
> > + while ( true )
> > + {
> > + irq = atomic_read(&u->irq_time);
> > + if ( likely( irq == atomic_cmpxchg(&u->irq_time, irq, 0)) )
> > + break;
> > + }
>
> Just use atomic_xchg()?
Thanks. I somehow missed this macro.
> > +
> > + while ( true )
> > + {
> > + hyp = atomic_read(&u->hyp_time);
> > + if ( likely( hyp == atomic_cmpxchg(&u->hyp_time, hyp, 0)) )
> > + break;
> > + }
> > +
> > + return irq + hyp;
>
> Ah, I didn't look into this patch until now.
>
> You can replace my comments about overflow of an int for patches 1 and 2
> with:
>
> Please modify the comment about not overflowing hinting to the value
> being reset when making scheduling decisions.
Will do.
> And this (of course) needs to be handled in all other schedulers, too.
>
Yes, the plan is to call this function in all schedulers. I skipped
this in RFC, because I wanted to discuss the general approch. I'll add
support for all other schedulers in the next version.
next prev parent reply other threads:[~2020-06-12 11:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 0:22 [RFC PATCH v1 0/6] Fair scheduling Volodymyr Babchuk
2020-06-12 0:22 ` [RFC PATCH v1 2/6] sched: track time spent in hypervisor tasks Volodymyr Babchuk
2020-06-12 4:43 ` Jürgen Groß
2020-06-12 11:30 ` Volodymyr Babchuk
2020-06-12 11:40 ` Jürgen Groß
2020-09-24 18:08 ` Volodymyr Babchuk
2020-09-25 17:22 ` Dario Faggioli
2020-09-25 20:21 ` Volodymyr Babchuk
2020-09-25 21:42 ` Dario Faggioli
2020-06-16 10:10 ` Jan Beulich
2020-06-18 2:50 ` Volodymyr Babchuk
2020-06-18 6:34 ` Jan Beulich
2020-06-12 0:22 ` [RFC PATCH v1 1/6] sched: track time spent in IRQ handler Volodymyr Babchuk
2020-06-12 4:36 ` Jürgen Groß
2020-06-12 11:26 ` Volodymyr Babchuk
2020-06-12 11:29 ` Julien Grall
2020-06-12 11:33 ` Volodymyr Babchuk
2020-06-12 12:21 ` Julien Grall
2020-06-12 20:08 ` Dario Faggioli
2020-06-12 22:25 ` Volodymyr Babchuk
2020-06-12 22:54 ` Julien Grall
2020-06-16 10:06 ` Jan Beulich
2020-06-12 0:22 ` [RFC PATCH v1 3/6] sched, credit2: improve scheduler fairness Volodymyr Babchuk
2020-06-12 4:51 ` Jürgen Groß
2020-06-12 11:38 ` Volodymyr Babchuk [this message]
2020-06-12 0:22 ` [RFC PATCH v1 5/6] tools: xentop: show time spent in IRQ and HYP states Volodymyr Babchuk
2020-06-12 0:22 ` [RFC PATCH v1 6/6] trace: add fair scheduling trace events Volodymyr Babchuk
2020-06-12 0:22 ` [RFC PATCH v1 4/6] xentop: collect IRQ and HYP time statistics Volodymyr Babchuk
2020-06-12 4:57 ` Jürgen Groß
2020-06-12 11:44 ` Volodymyr Babchuk
2020-06-12 12:45 ` Julien Grall
2020-06-12 22:16 ` Volodymyr Babchuk
2020-06-18 20:24 ` Volodymyr Babchuk
2020-06-18 20:34 ` Julien Grall
2020-06-18 23:35 ` Volodymyr Babchuk
2020-06-12 12:29 ` Julien Grall
2020-06-12 12:41 ` Jürgen Groß
2020-06-12 15:29 ` Dario Faggioli
2020-06-12 22:27 ` Volodymyr Babchuk
2020-06-13 6:22 ` Jürgen Groß
2020-06-18 2:58 ` Volodymyr Babchuk
2020-06-18 15:17 ` Julien Grall
2020-06-18 15:23 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33db319c8a533fc08b168d24c329533516d14f8b.camel@epam.com \
--to=volodymyr_babchuk@epam.com \
--cc=dfaggioli@suse.com \
--cc=george.dunlap@citrix.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).