From: Alexandru Stefan ISAILA <aisaila@bitdefender.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Petre Ovidiu PIRCALABU <ppircalabu@bitdefender.com>,
"tamas@tklengyel.com" <tamas@tklengyel.com>,
"wl@xen.org" <wl@xen.org>,
Razvan COJOCARU <rcojocaru@bitdefender.com>,
"george.dunlap@eu.citrix.com" <george.dunlap@eu.citrix.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"paul.durrant@citrix.com" <paul.durrant@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"roger.pau@citrix.com" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v8] x86/emulate: Send vm_event from emulate
Date: Mon, 9 Sep 2019 11:23:19 +0000 [thread overview]
Message-ID: <43ee49a9-23dc-495f-3cf2-7c75b7576e9d@bitdefender.com> (raw)
In-Reply-To: <9de8e959-139b-29cd-c4b4-24713106f71f@suse.com>
On 09.09.2019 14:15, Jan Beulich wrote:
> On 09.09.2019 13:03, Alexandru Stefan ISAILA wrote:
>>
>>
>> On 09.09.2019 13:49, Jan Beulich wrote:
>>> On 09.09.2019 12:01, Alexandru Stefan ISAILA wrote:
>>>> On 06.09.2019 18:46, Jan Beulich wrote:
>>>>> On 03.09.2019 16:01, Alexandru Stefan ISAILA wrote:
>>>>>> }
>>>>>> + /* Check if eny vm_event was sent */
>>>>>
>>>>> "any" and please add blank line ahead of your addition.
>>>>
>>>> I will correct this.
>>>>
>>>>>
>>>>>> + if ( err )
>>>>>> + goto out;
>>>>>
>>>>> And wait - why does this sit after the loop? Is that a re-basing
>>>>> mistake from when you had put on top of my uncommitted patch?
>>>>
>>>> This is done to skip the mapping part down the line. If there is an
>>>> error then we have to return _it_ and not the mapping.
>>>
>>> But after re-basing you could (and hence imo should) "goto out"
>>> right from the code blob you add to the loop. Which would then
>>> also eliminate the need for other "err" related adjustments you
>>> make.
>>>
>>
>> So you want me to have this patch base on your (x86/HVM: correct
>> hvmemul_map_linear_addr() for multi-page case) patch.
>
> No, explicitly not. The "re-basing" I used above was referring to
> you have moved away from basing your patch on mine.
>
Ok, I misunderstood, thanks for the explanation, I will have the patch
modified as I posted.
Thanks for the review,
Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-09-09 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 14:01 [Xen-devel] [PATCH v8] x86/emulate: Send vm_event from emulate Alexandru Stefan ISAILA
2019-09-06 15:46 ` Jan Beulich
2019-09-09 10:01 ` Alexandru Stefan ISAILA
2019-09-09 10:49 ` Jan Beulich
2019-09-09 11:03 ` Alexandru Stefan ISAILA
2019-09-09 11:15 ` Jan Beulich
2019-09-09 11:23 ` Alexandru Stefan ISAILA [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43ee49a9-23dc-495f-3cf2-7c75b7576e9d@bitdefender.com \
--to=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=paul.durrant@citrix.com \
--cc=ppircalabu@bitdefender.com \
--cc=rcojocaru@bitdefender.com \
--cc=roger.pau@citrix.com \
--cc=tamas@tklengyel.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).