From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v4 09/11] x86/intel_pstate: add a booting param to select the driver to load
Date: Fri, 24 Jul 2015 07:58:40 -0600 [thread overview]
Message-ID: <55B260B00200007800095395@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1435231021-22719-1-git-send-email-wei.w.wang@intel.com>
>>> On 25.06.15 at 13:17, <wei.w.wang@intel.com> wrote:
> By default, the old P-state driver (acpi-freq) is used. Adding
> "intel_pstate" to the Xen booting param list to enable the
> use of intel_pstate. However, if intel_pstate is enabled on a
> machine which does not support the driver (e.g. Nehalem), the
> old P-state driver will be loaded due to the failure loading of
> intel_pstate.
>
> Also, adding the intel_pstate booting parameter to
> xen-command-line.markdown.
>
> v4 changes:
> 1) moved the definition of "load_intel_pstate" right ahead of
> intel_pstate_init();
Didn't I ask for it to be moved _inside_ the function?
> --- a/xen/arch/x86/acpi/cpufreq/intel_pstate.c
> +++ b/xen/arch/x86/acpi/cpufreq/intel_pstate.c
> @@ -831,12 +831,18 @@ static void __init copy_cpu_funcs(struct pstate_funcs *funcs)
> pstate_funcs.get_vid = funcs->get_vid;
> }
>
> +static bool_t __initdata load_intel_pstate;
> +boolean_param("intel_pstate", load_intel_pstate);
> +
> int __init intel_pstate_init(void)
> {
> int cpu, rc = 0;
> const struct x86_cpu_id *id;
> struct cpu_defaults *cpu_info;
>
> + if (!load_intel_pstate)
> + return -ENODEV;
> +
With the variable then perhaps simply be named "load"?
Jan
prev parent reply other threads:[~2015-07-24 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 11:17 [PATCH v4 09/11] x86/intel_pstate: add a booting param to select the driver to load Wei Wang
2015-07-24 13:58 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B260B00200007800095395@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.w.wang@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).