From: Andrew Cooper <andrew.cooper3@citrix.com>
To: xen-devel@lists.xen.org
Subject: Re: [PATCH 1/2] x86/shadow: compile most write emulation code just once
Date: Thu, 10 Mar 2016 11:40:13 +0000 [thread overview]
Message-ID: <56E15D1D.4090001@citrix.com> (raw)
In-Reply-To: <56E156C202000078000DB2BA@prv-mh.provo.novell.com>
On 10/03/16 10:13, Jan Beulich wrote:
> No need to compile all of this code three times, as most of it really
> is guest mode independent. The savings are between 3k and 4k of binary
> code in my builds.
>
> No functional change (i.e. only formatting and naming changes) except
> for
> - sh_emulate_map_dest()'s user mode check corrected for the PV case
> (affecting debugging mode only, this isn't being split out)
> - simplifying the vaddr argument to emulate_gva_to_mfn() for the second
> part in the cross page write case
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-10 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 10:06 [PATCH 0/2] x86/shadow: further code size reduction Jan Beulich
2016-03-10 10:13 ` [PATCH 1/2] x86/shadow: compile most write emulation code just once Jan Beulich
2016-03-10 11:40 ` Andrew Cooper [this message]
[not found] ` <20160310121750.GB86157@deinos.phlegethon.org>
2016-03-10 13:13 ` Jan Beulich
2016-03-10 10:13 ` [PATCH 2/2] x86/shadow: avoid extra local array variable Jan Beulich
2016-03-10 11:43 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E15D1D.4090001@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).