From: George Dunlap <george.dunlap@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 4/8] libxl: Move check for local access to a funciton
Date: Wed, 16 Mar 2016 17:02:19 +0000 [thread overview]
Message-ID: <56E9919B.8070907@citrix.com> (raw)
In-Reply-To: <22249.37048.741425.106572@mariner.uk.xensource.com>
On 16/03/16 16:58, Ian Jackson wrote:
> George Dunlap writes ("[PATCH 4/8] libxl: Move check for local access to a funciton"):
>> From: George Dunlap <george.dunlap@eu.citrix.com>
>>
>> Move pygrub checks for local access ability into a separate function.
>>
>> Also reorganize libxl__device_disk_local_initiate_attach so that we
>> don't initialize dls->disk unless we actually end up doing a local
>> attach.
> ...
>> +static char * libxl__device_disk_find_local_path(libxl__gc *gc,
>> + const libxl_device_disk *disk) {
> ^ whitespace
Oops..
> ^ line length
I was about to say "it's nto clear to me how to make this shorter", but
then I could just not have the const align with the '(', couldn't I?
There's a line in another patch that has a similar problem / solution.
> I think I need to review this with `git diff -b' - can you give me a
> git branch for your series or shall I git-am it ?
I'm actually rather in the middle of some further work (I'm trying to
get the script to fail on a duplicate block device) -- would you mind
running git am?
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-16 17:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 16:09 [PATCH 0/8] tools: Allow HVM domains emulated access to disks provided by hotplug scripts George Dunlap
2016-03-16 16:09 ` [PATCH 1/8] tools/hotplug: Add a "dummy" hotplug script for testing George Dunlap
2016-03-16 16:54 ` Ian Jackson
2016-03-16 16:09 ` [PATCH 2/8] libxl: Remove redundant setting of phyical-device George Dunlap
2016-03-16 16:54 ` Ian Jackson
2016-03-16 16:09 ` [PATCH 3/8] tools/hotplug: Write physical-device-path in addition to physical-device George Dunlap
2016-03-16 16:56 ` Ian Jackson
2016-03-16 16:57 ` George Dunlap
2016-03-16 16:09 ` [PATCH 4/8] libxl: Move check for local access to a funciton George Dunlap
2016-03-16 16:58 ` Ian Jackson
2016-03-16 17:02 ` George Dunlap [this message]
2016-03-17 18:11 ` Ian Jackson
2016-03-21 15:35 ` George Dunlap
2016-03-16 16:09 ` [PATCH 5/8] libxl: Share logic for finding path between qemuu and pygrub George Dunlap
2016-03-17 18:22 ` Ian Jackson
2016-03-18 17:09 ` George Dunlap
2016-04-01 14:17 ` Ian Jackson
2016-03-16 16:09 ` [PATCH 6/8] libxl: Allow local access for block devices with hotplug scripts George Dunlap
2016-03-17 18:36 ` Ian Jackson
2016-03-18 17:17 ` George Dunlap
2016-03-16 16:09 ` [PATCH 7/8] docs: Document block-script protocol George Dunlap
2016-03-16 22:57 ` Jim Fehlig
2016-03-17 9:55 ` George Dunlap
2016-03-17 18:38 ` Ian Jackson
2016-03-16 16:09 ` [PATCH 8/8] DO NOT APPLY libxl: Change hotplug script interface to use physical-device-path George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E9919B.8070907@citrix.com \
--to=george.dunlap@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).