From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Joao Martins <joao.m.martins@oracle.com>
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 4/5] x86/time: refactor read_platform_stime()
Date: Mon, 21 Mar 2016 13:08:21 +0000 [thread overview]
Message-ID: <56EFF245.6030800@citrix.com> (raw)
In-Reply-To: <56EFDEF4.2030601@oracle.com>
On 21/03/16 11:45, Joao Martins wrote:
>
> All fixed, though I found one change missing in this series, specifically on
> time_calibration_std_rendezvous. Otherwise this commit would break compilation.
> See chunk below for the change I am adding:
>
> @@ -1377,7 +1380,7 @@ static void time_calibration_std_rendezvous(void *_r)
> {
> while ( atomic_read(&r->semaphore) != (total_cpus - 1) )
> cpu_relax();
> - r->master_stime = read_platform_stime();
> + r->master_stime = read_platform_stime(NULL);
> mb(); /* write r->master_stime /then/ signal */
> atomic_inc(&r->semaphore);
> }
>
> Having this fixed, could I still keep your Reviewed-by?
Yes - that's fine.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-21 13:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 16:12 [PATCH 0/5] x86/time: PVCLOCK_TSC_STABLE_BIT support Joao Martins
2016-03-17 16:12 ` [PATCH 1/5] public/xen.h: add flags field to vcpu_time_info Joao Martins
2016-03-18 20:12 ` Andrew Cooper
2016-03-21 11:42 ` Joao Martins
2016-03-21 11:43 ` Andrew Cooper
2016-03-21 11:51 ` Joao Martins
2016-03-21 15:10 ` Jan Beulich
2016-03-21 15:27 ` Andrew Cooper
2016-03-21 15:40 ` Joao Martins
2016-03-17 16:12 ` [PATCH 2/5] x86/time: implement tsc as clocksource Joao Martins
2016-03-18 20:21 ` Andrew Cooper
2016-03-21 11:43 ` Joao Martins
2016-03-22 12:41 ` Joao Martins
2016-03-22 12:46 ` Jan Beulich
2016-03-22 15:51 ` Joao Martins
2016-03-22 16:02 ` Jan Beulich
2016-03-22 20:40 ` Joao Martins
2016-03-23 7:28 ` Jan Beulich
2016-03-23 12:05 ` Joao Martins
2016-03-23 14:05 ` Jan Beulich
2016-03-17 16:12 ` [PATCH 3/5] x86/time: streamline platform time init on plt_init() Joao Martins
2016-03-18 20:32 ` Andrew Cooper
2016-03-21 11:45 ` Joao Martins
2016-03-17 16:12 ` [PATCH 4/5] x86/time: refactor read_platform_stime() Joao Martins
2016-03-18 20:34 ` Andrew Cooper
2016-03-21 11:45 ` Joao Martins
2016-03-21 13:08 ` Andrew Cooper [this message]
2016-03-17 16:12 ` [PATCH 5/5] x86/time: implement PVCLOCK_TSC_STABLE_BIT Joao Martins
2016-03-18 20:58 ` Andrew Cooper
2016-03-21 11:50 ` Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EFF245.6030800@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=joao.m.martins@oracle.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).