From: Julien Grall <julien.grall@arm.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>, xen-devel@lists.xen.org
Cc: stefano.stabellini@citrix.com, shannon.zhao@linaro.org,
peter.huangpeng@huawei.com
Subject: Re: [PATCH v6 04/22] arm/gic: Add a new callback for creating MADT table for Dom0
Date: Mon, 21 Mar 2016 15:18:39 +0000 [thread overview]
Message-ID: <56F010CF.6030906@arm.com> (raw)
In-Reply-To: <1458207668-12012-5-git-send-email-zhaoshenglong@huawei.com>
Hi Shannon,
On 17/03/2016 09:40, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> Add a new member in gic_hw_operations which is used to creat MADT table
s/create/create/
> for Dom0.
>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
> xen/arch/arm/gic-v2.c | 34 ++++++++++++++++++++++++++++++++++
> xen/arch/arm/gic-v3.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
> xen/arch/arm/gic.c | 5 +++++
> xen/include/asm-arm/gic.h | 3 +++
> 4 files changed, 89 insertions(+)
>
> diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
> index 0fcb894..02db5f2 100644
> --- a/xen/arch/arm/gic-v2.c
> +++ b/xen/arch/arm/gic-v2.c
> @@ -685,6 +685,35 @@ static void __init gicv2_dt_init(void)
> }
>
> #ifdef CONFIG_ACPI
> +static u32 gicv2_make_hwdom_madt(const struct domain *d, u32 offset)
> +{
> + struct acpi_subtable_header *header;
> + struct acpi_madt_generic_interrupt *host_gicc, *gicc;
> + u32 i, size, table_len = 0;
> + u8 *base_ptr = d->arch.efi_acpi_table + offset;
> +
> + header = acpi_table_get_entry_madt(ACPI_MADT_TYPE_GENERIC_INTERRUPT, 0);
> + if ( !header )
> + panic("Can't get GICC entry");
I would prefer if you return an error here. In the future we may want to
support hardware domain creation later (see the xen option hardware_dom).
> + host_gicc = container_of(header, struct acpi_madt_generic_interrupt,
> + header);
> +
> + size = sizeof(struct acpi_madt_generic_interrupt);
> + /* Add Generic Interrupt */
> + for ( i = 0; i < d->max_vcpus; i++ )
> + {
> + gicc = (struct acpi_madt_generic_interrupt *)(base_ptr + table_len);
> + ACPI_MEMCPY(gicc, host_gicc, size);
> + gicc->cpu_interface_number = i;
> + gicc->uid = i;
> + gicc->flags = ACPI_MADT_ENABLED;
> + gicc->arm_mpidr = vcpuid_to_vaffinity(i);
What about the other fields?
* parking_version: DOM0 will always use PSCI => should be set to 0
* performance_interrupt: There is currently PMU support for DOM0
* gic{v,h}_base_address/vgic_interrupt: they are used by Xen => should
not be exposed to the guest
> + table_len += size;
> + }
> +
> + return table_len;
> +}
> +
> static int __init
> gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header,
> const unsigned long end)
[...]
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index f83fd88..d9fce4b 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -1236,6 +1236,48 @@ static void __init gicv3_dt_init(void)
> }
>
> #ifdef CONFIG_ACPI
> +static u32 gicv3_make_hwdom_madt(const struct domain *d, u32 offset)
> +{
> + struct acpi_subtable_header *header;
> + struct acpi_madt_generic_interrupt *host_gicc, *gicc;
> + struct acpi_madt_generic_redistributor *gicr;
> + u8 *base_ptr = d->arch.efi_acpi_table + offset;
> + u32 i, table_len = 0, size;
> +
> + /* Add Generic Interrupt */
> + header = acpi_table_get_entry_madt(ACPI_MADT_TYPE_GENERIC_INTERRUPT, 0);
> + if ( !header )
> + panic("Can't get GICC entry");
> + host_gicc = container_of(header, struct acpi_madt_generic_interrupt,
> + header);
> +
> + size = sizeof(struct acpi_madt_generic_interrupt);
> + for ( i = 0; i < d->max_vcpus; i++ )
> + {
> + gicc = (struct acpi_madt_generic_interrupt *)(base_ptr + table_len);
> + ACPI_MEMCPY(gicc, host_gicc, size);
> + gicc->cpu_interface_number = i;
> + gicc->uid = i;
> + gicc->flags = ACPI_MADT_ENABLED;
> + gicc->arm_mpidr = vcpuid_to_vaffinity(i);
> + table_len += size;
Ditto for the fields.
Furthermore, you use the Generic Redistributor table to describe the
redistributor regions. So the field gicr_base_address should be set to 0.
> + }
> +
> + /* Add Generic Redistributor */
> + size = sizeof(struct acpi_madt_generic_redistributor);
> + for ( i = 0; i < d->arch.vgic.nr_regions; i++ )
> + {
> + gicr = (struct acpi_madt_generic_redistributor *)(base_ptr + table_len);
> + gicr->header.type = ACPI_MADT_TYPE_GENERIC_REDISTRIBUTOR;
> + gicr->header.length = size;
> + gicr->base_address = d->arch.vgic.rdist_regions[i].base;
> + gicr->length = d->arch.vgic.rdist_regions[i].size;
> + table_len += size;
> + }
> +
> + return table_len;
> +}
> +
> static int __init
> gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header,
> const unsigned long end)
[...]
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-21 15:18 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 9:40 [PATCH v6 00/22] Prepare UEFI and ACPI tables for Dom0 on ARM64 Shannon Zhao
2016-03-17 9:40 ` [PATCH v6 01/22] arm/acpi: Estimate memory required for acpi/efi tables Shannon Zhao
2016-03-18 18:44 ` Julien Grall
2016-03-21 13:01 ` Jan Beulich
2016-03-22 13:01 ` Shannon Zhao
2016-03-22 0:28 ` Julien Grall
2016-03-24 12:36 ` Stefano Stabellini
2016-03-17 9:40 ` [PATCH v6 02/22] arm/acpi: Add a helper function to get the acpi table offset Shannon Zhao
2016-03-21 12:16 ` Julien Grall
2016-03-24 12:32 ` Stefano Stabellini
2016-03-17 9:40 ` [PATCH v6 03/22] arm/acpi: Prepare FADT table for Dom0 Shannon Zhao
2016-03-21 12:25 ` Julien Grall
2016-03-17 9:40 ` [PATCH v6 04/22] arm/gic: Add a new callback for creating MADT " Shannon Zhao
2016-03-21 15:18 ` Julien Grall [this message]
2016-03-17 9:40 ` [PATCH v6 05/22] arm/acpi: Prepare " Shannon Zhao
2016-03-21 15:26 ` Julien Grall
2016-03-21 15:51 ` Jan Beulich
2016-03-17 9:40 ` [PATCH v6 06/22] arm/acpi: Prepare STAO " Shannon Zhao
2016-03-21 15:31 ` Julien Grall
2016-03-17 9:40 ` [PATCH v6 07/22] arm/acpi: Prepare XSDT " Shannon Zhao
2016-03-21 15:43 ` Julien Grall
2016-03-17 9:40 ` [PATCH v6 08/22] arm/acpi: Prepare RSDP " Shannon Zhao
2016-03-21 15:47 ` Julien Grall
2016-03-17 9:40 ` [PATCH v6 09/22] arm/p2m: Add helper functions to map memory regions Shannon Zhao
2016-03-21 15:52 ` Julien Grall
2016-03-22 13:05 ` Shannon Zhao
2016-03-22 15:59 ` Julien Grall
2016-03-17 9:40 ` [PATCH v6 10/22] arm/acpi: Map all other tables for Dom0 Shannon Zhao
2016-03-21 15:57 ` Julien Grall
2016-03-17 9:40 ` [PATCH v6 11/22] arm/acpi: Prepare EFI system table " Shannon Zhao
2016-03-21 16:10 ` Julien Grall
2016-03-22 13:06 ` Shannon Zhao
2016-03-22 13:24 ` Jan Beulich
2016-03-17 9:40 ` [PATCH v6 12/22] arm/acpi: Prepare EFI memory descriptor " Shannon Zhao
2016-03-21 16:51 ` Julien Grall
2016-03-22 13:16 ` Shannon Zhao
2016-03-22 16:04 ` Julien Grall
2016-03-24 15:06 ` Shannon Zhao
2016-03-24 15:23 ` Julien Grall
2016-03-24 12:39 ` Stefano Stabellini
2016-03-17 9:40 ` [PATCH v6 13/22] arm/acpi: Map the new created EFI and ACPI tables to Dom0 Shannon Zhao
2016-03-22 0:42 ` Julien Grall
2016-03-22 13:18 ` Shannon Zhao
2016-03-22 16:16 ` Julien Grall
2016-03-24 14:59 ` Shannon Zhao
2016-03-24 15:35 ` Julien Grall
2016-03-17 9:41 ` [PATCH v6 14/22] arm/acpi: Create min DT stub for Dom0 Shannon Zhao
2016-03-22 1:07 ` Julien Grall
2016-03-22 13:23 ` Shannon Zhao
2016-03-17 9:41 ` [PATCH v6 15/22] arm/acpi: Permit access all Xen unused SPIs " Shannon Zhao
2016-03-22 18:18 ` Julien Grall
2016-03-24 15:01 ` Shannon Zhao
2016-03-24 15:37 ` Julien Grall
2016-03-25 7:13 ` Shannon Zhao
2016-03-17 9:41 ` [PATCH v6 16/22] arm/acpi: Configure SPI interrupt type and route to Dom0 dynamically Shannon Zhao
2016-03-22 19:17 ` Julien Grall
2016-03-24 12:41 ` Stefano Stabellini
2016-03-17 9:41 ` [PATCH v6 17/22] arm/gic: Add a new callback to deny Dom0 access to GIC regions Shannon Zhao
2016-03-22 19:33 ` Julien Grall
2016-03-24 12:45 ` Stefano Stabellini
2016-03-24 15:03 ` Shannon Zhao
2016-03-24 15:39 ` Julien Grall
2016-03-17 9:41 ` [PATCH v6 18/22] arm/acpi: Permit MMIO access of Xen unused devices for Dom0 Shannon Zhao
2016-03-23 11:50 ` Julien Grall
2016-03-17 9:41 ` [PATCH v6 19/22] hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-03-17 10:42 ` Jan Beulich
2016-03-17 11:04 ` Shannon Zhao
2016-03-17 11:29 ` Jan Beulich
2016-03-17 11:56 ` Shannon Zhao
2016-03-17 12:42 ` Jan Beulich
2016-03-17 9:41 ` [PATCH v6 20/22] xen/acpi: Fix event-channel interrupt when booting with ACPI Shannon Zhao
2016-03-23 12:15 ` Julien Grall
2016-03-17 9:41 ` [PATCH v6 21/22] xen/arm: Add a hypercall for device mmio mapping Shannon Zhao
2016-03-17 9:41 ` [PATCH v6 22/22] xen/arm64: Add ACPI support Shannon Zhao
2016-03-17 10:52 ` Jan Beulich
2016-03-17 11:03 ` Shannon Zhao
2016-03-17 11:31 ` Jan Beulich
2016-03-17 13:10 ` Shannon Zhao
2016-03-17 13:24 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F010CF.6030906@arm.com \
--to=julien.grall@arm.com \
--cc=peter.huangpeng@huawei.com \
--cc=shannon.zhao@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).