From: Juergen Gross <jgross@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: George.Dunlap@eu.citrix.com, stefano.stabellini@eu.citrix.com,
ian.jackson@eu.citrix.com, cyliu@suse.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH v3 1/5] libxl: make libxl__need_xenpv_qemu() operate on domain config
Date: Fri, 25 Mar 2016 07:13:58 +0100 [thread overview]
Message-ID: <56F4D726.7060908@suse.com> (raw)
In-Reply-To: <20160324202835.GC14940@citrix.com>
On 24/03/16 21:28, Wei Liu wrote:
> On Wed, Mar 23, 2016 at 01:24:03PM +0100, Juergen Gross wrote:
>> libxl__need_xenpv_qemu() is called with configuration data for console,
>> vfbs, disks and channels today in order to evaluate the need for
>> starting a device model for a pv domain.
>>
>> The console data is local to the caller and setup in a way to never
>> require a device model. All other data is taken from the domain config
>> structure.
>>
>> In order to support other device backends via qemu change the interface
>> of libxl__need_xenpv_qemu() to take the domain config structure as
>> input instead of the single device arrays.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> V2: Return false if libxl__get_domid() fails as requested by George Dunlap
>
> This is a bug that should be addressed properly -- returning true or
> false doesn't make sense in the context of this function.
>
> It would make sense to push calling libxl__get_domid to the sole caller,
> then expose a new parameter called backend_id for
> libxl__need_xenpv_qemu. A patch like that would also be easily
> backportable. What do you think?
Hmm, right now there is only one caller. Patch 4 adds another one. I'd
rather return a negative value for an error, and 0 or 1 indicating the
device model isn't or is to be started.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-25 6:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 12:24 [PATCH v3 0/5] libxl: add support for qemu base pvusb backend Juergen Gross
2016-03-23 12:24 ` [PATCH v3 1/5] libxl: make libxl__need_xenpv_qemu() operate on domain config Juergen Gross
2016-03-24 20:28 ` Wei Liu
2016-03-25 6:13 ` Juergen Gross [this message]
2016-03-23 12:24 ` [PATCH v3 2/5] libxl: add new pvusb backend "qusb" provided by qemu Juergen Gross
2016-03-25 2:23 ` Chun Yan Liu
[not found] ` <56F5119C02000066000C0F24@suse.com>
2016-03-25 6:29 ` Juergen Gross
2016-03-25 6:38 ` Chun Yan Liu
2016-03-23 12:24 ` [PATCH v3 3/5] libxl: add service function to check whether device model is running Juergen Gross
2016-03-24 20:28 ` Wei Liu
2016-03-23 12:24 ` [PATCH v3 4/5] libxl: check for dynamic device model start required Juergen Gross
2016-03-25 2:06 ` Chun Yan Liu
[not found] ` <56F50DC102000066000C0EF4@suse.com>
2016-03-25 6:25 ` Juergen Gross
2016-03-25 6:29 ` Chun Yan Liu
2016-03-23 12:24 ` [PATCH v3 5/5] libxl: add domain config parameter to force start of qemu Juergen Gross
2016-03-24 20:28 ` Wei Liu
2016-03-24 20:35 ` Wei Liu
2016-03-25 6:20 ` Juergen Gross
2016-03-25 6:16 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F4D726.7060908@suse.com \
--to=jgross@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=cyliu@suse.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).