Re: [PATCH v12 23/26] COLO nic: implement COLO nic subkind

From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Lars Kurth <lars.kurth@citrix.com>,
	Li Zhijian <lizhijian@cn.fujitsu.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Wen Congyang <wency@cn.fujitsu.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jiang Yunhong <yunhong.jiang@intel.com>,
	Dong Eddie <eddie.dong@intel.com>,
	xen devel <xen-devel@lists.xen.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Gui Jianfeng <guijianfeng@cn.fujitsu.com>,
	Shriram Rajagopalan <rshriram@cs.ubc.ca>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Yang Hongyang <hongyang.yang@easystack.cn>
Subject: Re: [PATCH v12 23/26] COLO nic: implement COLO nic subkind
Date: Mon, 28 Mar 2016 11:20:39 +0800	[thread overview]
Message-ID: <56F8A307.7010607@cn.fujitsu.com> (raw)
In-Reply-To: <20160325122319.GA20441@citrix.com>

On 03/25/2016 08:23 PM, Wei Liu wrote:
> On Fri, Mar 25, 2016 at 02:09:04PM +0800, Changlong Xie wrote:
>> On 03/25/2016 12:05 AM, Ian Jackson wrote:
>>> Changlong Xie writes ("[PATCH v12 23/26] COLO nic: implement COLO nic subkind"):
>>>> From: Wen Congyang <wency@cn.fujitsu.com>
>>>>
>>>> implement COLO nic subkind.
>>> ...
>>>> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
>>>> index a206d68..a8be078 100644
>>>> --- a/tools/libxl/libxl_types.idl
>>>> +++ b/tools/libxl/libxl_types.idl
>>>> @@ -599,6 +599,9 @@ libxl_device_nic = Struct("device_nic", [
>>>>       ("rate_bytes_per_interval", uint64),
>>>>       ("rate_interval_usecs", uint32),
>>>>       ("gatewaydev", string),
>>>> +    # forward device that only used in COLO, it forwards
>>>> +    # the network requests from client to secondary vm
>>>> +    ("forwarddev", string)
>>>
>>> Sorry I didn't ask for this last time, but I think this parameter
>>> ought to have `colo' or `coloft' in its name somewhere.
>>>
>>> How about `coloft_forwarddev' ?
>>>
>>> This is not critical for 4.7 if we aren't trying to provide a stable
>>> API.  Please make sure a copy of the API stability warning text I
>>
>> Could you point where is the "API stability warning text", i've went through
>> v11/v12 and don't have any clue.
>>
>
> See Ian's comment on 20/26 -- I will copy the most relevant snippet

Yes, i just found Ian's comments, it's very strange that the reply email 
is not in my colo V12 thread.

Thanks
	-Xie
> here:
>
>    So can you please add comments to this patch saying
>
>      Note that the COLO configuration settings should be considered
>      unstable.  They may change incompatibly in future versions of
>      Xen.
>
>    This should appear (at least) three times: in xl.pod.1,
>    xl-disk-configuration.txt and libxl_types.idl.  With such a change, I
>    will ack this patch.
>
> Wei.
>
>> Thanks
>> 	-Xie
>>> mentioned earlier (either because the previous patch put it here, or
>>> adding it to this patch).
>>>
>>> Thanks,
>>> Ian.
>>>
>>>
>>> .
>>>
>>
>>
>
>
> .
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel