From: George Dunlap <george.dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Chong Li <lichong659@gmail.com>
Cc: Chong Li <chong.li@wustl.edu>,
george.dunlap@eu.citrix.com, dario.faggioli@citrix.com,
xen-devel@lists.xen.org, mengxu@cis.upenn.edu,
dgolomb@seas.upenn.edu
Subject: Re: [PATCH] xen: enable per-VCPU parameter for RTDS
Date: Tue, 5 Apr 2016 10:25:06 +0100 [thread overview]
Message-ID: <57038472.3030407@citrix.com> (raw)
In-Reply-To: <57038C1F02000078000E30A9@prv-mh.provo.novell.com>
On 05/04/16 08:57, Jan Beulich wrote:
>>>> On 05.04.16 at 03:07, <lichong659@gmail.com> wrote:
>> Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced
>> a bug: it made it possible, in Credit and Credit2, when doing domain
>> or vcpu parameters' manipulation, to leave the hypervisor with a
>> spinlock held and interrupts disabled.
>>
>> Fix it.
>>
>> Signed-off-by: Chong Li <chong.li@wustl.edu>
>>
>> Acked-by: Dario Faggioli <dario.faggioli@citrix.com>
>
> This appears to be the 3rd variant of the patch, all with the same
> bogus subject, and no versioning information at all. Please
> remember that mails can arrive out of order, so there's no way
> to reliably tell which one got sent first. So for this to go in I'm
> expecting you to re-send with a proper subject and an indication
> that this is not the initial version of the patch.
And since this version of the patch is functionally different than the
one Dario acked, you should drop his Acked-by as well.
Thanks for being responsive in fixing this bug; and sorry for all the
criticism, but OSS development is very detail-oriented, and it takes a
while to internalize all the rules for how things should be done.
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-05 9:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 1:07 [PATCH] xen: enable per-VCPU parameter for RTDS Chong Li
2016-04-05 1:44 ` Meng Xu
2016-04-05 7:57 ` Jan Beulich
2016-04-05 9:25 ` George Dunlap [this message]
2016-04-05 9:43 ` Dario Faggioli
2016-04-05 12:45 ` Wei Liu
-- strict thread matches above, loose matches on Subject: below --
2016-04-04 22:45 Chong Li
2016-04-04 23:14 ` Andrew Cooper
2016-04-05 9:18 ` George Dunlap
2016-04-05 9:39 ` Dario Faggioli
2016-04-04 21:21 Chong Li
2016-04-04 22:05 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57038472.3030407@citrix.com \
--to=george.dunlap@citrix.com \
--cc=JBeulich@suse.com \
--cc=chong.li@wustl.edu \
--cc=dario.faggioli@citrix.com \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=lichong659@gmail.com \
--cc=mengxu@cis.upenn.edu \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).