From: "Jan Beulich" <jbeulich@suse.com>
To: Ben.Sanda@dornerworks.com
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 1/5] xentrace: Common Support for get_pg_owner/put_pg_owner on ARM and x86
Date: Sun, 17 Apr 2016 01:58:19 -0600 [thread overview]
Message-ID: <5713502B02000078000E6A39@prv-mh.provo.novell.com> (raw)
In-Reply-To: <A2A949C387F3A54C9B4DAC2DCD2E9A85E333CDB5@Quimby.dw.local>
>>> Ben Sanda <Ben.Sanda@dornerworks.com> 04/14/16 10:03 PM >>>
>>> +void put_pg_owner(struct domain *pg_owner) {
>>> + rcu_unlock_domain(pg_owner);
>>> +}
> I cannot see why this then can't just become an inline function.
>
>I investigated this but making put_pg_owner() static inline creates a
>circular dependency on rcu_unlock_domain(), which is also a static
>inline function. The two functions are in different header files and
>this creates a dependency on the one header being included by the
>other, which, depending on how C files include them, creates an
>implicit definition error by the compiler. For now I will leave the
>function as is.
While generally macros are undesirable in place of inline functions,
with the type checking aspect not being relevant here (both functions
have identically typed parameters), using a #define here instead of an
out of line call to a function which does nothing other than adjust the
preempt count seems warranted if the include dependency can't be
addressed in a satisfactory manner.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-17 7:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 18:48 [PATCH v3 0/5] xentrace/xenalyze Support on ARM Benjamin Sanda
2016-04-04 18:48 ` [PATCH v3 1/5] xentrace: Common Support for get_pg_owner/put_pg_owner on ARM and x86 Benjamin Sanda
2016-04-04 23:05 ` Andrew Cooper
2016-04-05 8:12 ` Jan Beulich
2016-04-14 19:59 ` Ben Sanda
2016-04-17 7:58 ` Jan Beulich [this message]
2016-04-04 18:48 ` [PATCH v3 2/5] xentrace: Memory/Page Mapping support for DOMID_XEN on ARM Benjamin Sanda
2016-04-08 10:42 ` Julien Grall
2016-04-08 15:49 ` Jan Beulich
2016-04-08 17:58 ` Andrew Cooper
2016-04-11 9:52 ` George Dunlap
2016-04-12 15:53 ` Julien Grall
2016-04-14 19:52 ` Ben Sanda
2016-04-20 12:48 ` Julien Grall
2016-04-22 9:42 ` Stefano Stabellini
2016-04-22 17:01 ` Julien Grall
2016-04-04 18:48 ` [PATCH v3 3/5] xentrace: Timestamp support for ARM platform Benjamin Sanda
2016-04-08 10:50 ` Julien Grall
2016-04-11 14:56 ` Konrad Rzeszutek Wilk
2016-04-04 18:48 ` [PATCH v3 4/5] xentrace: Trace Buffer Initialization on ARM Benjamin Sanda
2016-04-08 10:53 ` Julien Grall
2016-04-04 18:48 ` [PATCH v3 5/5] xenalyze: Build for Both ARM and x86 Platforms Benjamin Sanda
2016-04-05 8:09 ` [PATCH v3 0/5] xentrace/xenalyze Support on ARM Jan Beulich
2016-04-06 16:51 ` Ben Sanda
2016-04-06 16:59 ` Andrew Cooper
2016-04-06 17:03 ` Ben Sanda
2016-04-08 14:44 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5713502B02000078000E6A39@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=Ben.Sanda@dornerworks.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).