From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Lagerwall Subject: Re: [PATCH v9 16/27] x86, xsplice: Print payload's symbol name and payload name in backtraces Date: Tue, 26 Apr 2016 12:06:03 +0100 Message-ID: <571F4B9B.5000405@citrix.com> References: <1461598514-5440-1-git-send-email-konrad.wilk@oracle.com> <1461598514-5440-17-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1av0ok-0000By-A4 for xen-devel@lists.xenproject.org; Tue, 26 Apr 2016 11:06:10 +0000 In-Reply-To: <1461598514-5440-17-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Konrad Rzeszutek Wilk , konrad@kernel.org, xen-devel@lists.xenproject.org, sasha.levin@oracle.com, andrew.cooper3@citrix.com, mpohlack@amazon.de Cc: Keir Fraser , Ian Jackson , Jan Beulich , Tim Deegan List-Id: xen-devel@lists.xenproject.org T24gMDQvMjUvMjAxNiAwNDozNSBQTSwgS29ucmFkIFJ6ZXN6dXRlayBXaWxrIHdyb3RlOgpzbmlw Cj4gK3N0YXRpYyBERUZJTkVfUkNVX1JFQURfTE9DSyhyY3VfYXBwbGllZF9sb2NrKTsKPiAgIHN0 YXRpYyBMSVNUX0hFQUQoYXBwbGllZF9saXN0KTsKPgo+ICAgc3RhdGljIHVuc2lnbmVkIGludCBw YXlsb2FkX2NudDsKPiBAQCAtNTYsNiArNTcsOCBAQCBzdHJ1Y3QgcGF5bG9hZCB7Cj4gICAgICAg dW5zaWduZWQgaW50IG5mdW5jczsgICAgICAgICAgICAgICAgIC8qIE5yIG9mIGZ1bmN0aW9ucyB0 byBwYXRjaC4gKi8KPiAgICAgICBjb25zdCBzdHJ1Y3QgeHNwbGljZV9zeW1ib2wgKnN5bXRhYjsg LyogQWxsIHN5bWJvbHMuICovCj4gICAgICAgY29uc3QgY2hhciAqc3RydGFiOyAgICAgICAgICAg ICAgICAgIC8qIFBvaW50ZXIgdG8gLnN0cnRhYi4gKi8KPiArICAgIHN0cnVjdCB2aXJ0dWFsX3Jl Z2lvbiByZWdpb247ICAgICAgICAvKiBzeW1ib2wsIGJ1Zy5mcmFtZSBwYXRjaGluZyBhbmQKPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBleGNlcHRpb24gdGFi bGUgKHg4NikuICovCj4gICAgICAgdW5zaWduZWQgaW50IG5zeW1zOyAgICAgICAgICAgICAgICAg IC8qIE5yIG9mIGVudHJpZXMgaW4gLnN0cnRhYiBhbmQgc3ltYm9scy4gKi8KPiAgICAgICBjaGFy IG5hbWVbWEVOX1hTUExJQ0VfTkFNRV9TSVpFXTsgICAgLyogTmFtZSBvZiBpdC4gKi8KPiAgIH07 Cj4gQEAgLTE0Miw2ICsxNDUsNTUgQEAgdm9pZCAqeHNwbGljZV9zeW1ib2xzX2xvb2t1cF9ieV9u YW1lKGNvbnN0IGNoYXIgKnN5bW5hbWUpCj4gICAgICAgcmV0dXJuIDA7Cj4gICB9Cj4KPiArc3Rh dGljIGNvbnN0IGNoYXIgKnhzcGxpY2Vfc3ltYm9sc19sb29rdXAodW5zaWduZWQgbG9uZyBhZGRy LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBs b25nICpzeW1ib2xzaXplLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBsb25nICpvZmZzZXQsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGNoYXIgKm5hbWVidWYpCj4gK3sKPiArICAgIGNvbnN0IHN0cnVjdCBw YXlsb2FkICpkYXRhOwo+ICsgICAgdW5zaWduZWQgaW50IGksIGJlc3Q7Cj4gKyAgICBjb25zdCB2 b2lkICp2YSA9IChjb25zdCB2b2lkICopYWRkcjsKPiArICAgIGNvbnN0IGNoYXIgKm4gPSBOVUxM Owo+ICsKPiArICAgIC8qCj4gKyAgICAgKiBPbmx5IFJDVSBsb2NraW5nIHNpbmNlIHRoaXMgbGlz dCBpcyBvbmx5IGV2ZXIgY2hhbmdlZCBkdXJpbmcgYXBwbHkKPiArICAgICAqIG9yIHJldmVydCBj b250ZXh0LiBBbmQgaW4gY2FzZSBpdCBkaWVzIHRoZXJlIHdlIG5lZWQgYW4gc2FmZSBsaXN0Lgo+ ICsgICAgICovCj4gKyAgICByY3VfcmVhZF9sb2NrKCZyY3VfYXBwbGllZF9sb2NrKTsKPiArICAg IGxpc3RfZm9yX2VhY2hfZW50cnlfcmN1ICggZGF0YSwgJmFwcGxpZWRfbGlzdCwgYXBwbGllZF9s aXN0ICkKPiArICAgIHsKPiArICAgICAgICBpZiAoIHZhIDwgZGF0YS0+dGV4dF9hZGRyICYmCj4g KyAgICAgICAgICAgICB2YSA+PSAoZGF0YS0+dGV4dF9hZGRyICsgZGF0YS0+cGFnZXMgKiBQQUdF X1NJWkUpICkKClRoaXMgY2FsY3VsYXRpb24gaXMgd3JvbmcgZHVlIHRvIHRoZSB1c2Ugb2Ygdm9p ZCAqIGFuZCByZXN1bHRzIGluIAppbmNvcnJlY3QgYmFja3RyYWNlIHJlc3VsdHMuCgpZb3UgYWxz byBuZWVkIHRvIGhhdmUgfHwgcmF0aGVyIHRoYW4gJiYuCgpBZGRpdGlvbmFsbHksIEkgdGhpbmsg aXQgc2hvdWxkIHVzZSBkYXRhLT50ZXh0X3NpemUgcmF0aGVyIHRoYW4gCmRhdGEtPnBhZ2VzICog UEFHRV9TSVpFLgoKPiArICAgICAgICAgICAgY29udGludWU7Cj4gKwo+ICsgICAgICAgIGJlc3Qg PSBVSU5UX01BWDsKPiArCj4gKyAgICAgICAgZm9yICggaSA9IDA7IGkgPCBkYXRhLT5uc3ltczsg aSsrICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIGlmICggZGF0YS0+c3ltdGFiW2ldLnZh bHVlIDw9IHZhICYmCj4gKyAgICAgICAgICAgICAgICAgKGJlc3QgPT0gVUlOVF9NQVggfHwKPiAr ICAgICAgICAgICAgICAgICAgZGF0YS0+c3ltdGFiW2Jlc3RdLnZhbHVlIDwgZGF0YS0+c3ltdGFi W2ldLnZhbHVlKSApCj4gKyAgICAgICAgICAgICAgICBiZXN0ID0gaTsKPiArICAgICAgICB9Cj4g Kwo+ICsgICAgICAgIGlmICggYmVzdCA9PSBVSU5UX01BWCApCj4gKyAgICAgICAgICAgIGJyZWFr Owo+ICsKPiArICAgICAgICBpZiAoIHN5bWJvbHNpemUgKQo+ICsgICAgICAgICAgICAqc3ltYm9s c2l6ZSA9IGRhdGEtPnN5bXRhYltiZXN0XS5zaXplOwo+ICsgICAgICAgIGlmICggb2Zmc2V0ICkK PiArICAgICAgICAgICAgKm9mZnNldCA9IHZhIC0gZGF0YS0+c3ltdGFiW2Jlc3RdLnZhbHVlOwo+ ICsgICAgICAgIGlmICggbmFtZWJ1ZiApCj4gKyAgICAgICAgICAgIHN0cmxjcHkobmFtZWJ1Ziwg ZGF0YS0+bmFtZSwgS1NZTV9OQU1FX0xFTik7Cj4gKwo+ICsgICAgICAgIG4gPSBkYXRhLT5zeW10 YWJbYmVzdF0ubmFtZTsKPiArICAgICAgICBicmVhazsKPiArICAgIH0KPiArICAgIHJjdV9yZWFk X3VubG9jaygmcmN1X2FwcGxpZWRfbG9jayk7Cj4gKwo+ICsgICAgcmV0dXJuIG47Cj4gK30KPiAr Cj4gICBzdGF0aWMgc3RydWN0IHBheWxvYWQgKmZpbmRfcGF5bG9hZChjb25zdCBjaGFyICpuYW1l KQo+ICAgewo+ICAgICAgIHN0cnVjdCBwYXlsb2FkICpkYXRhLCAqZm91bmQgPSBOVUxMOwo+IEBA IC0zNjYsNiArNDE4LDcgQEAgc3RhdGljIGludCBwcmVwYXJlX3BheWxvYWQoc3RydWN0IHBheWxv YWQgKnBheWxvYWQsCj4gICAgICAgY29uc3Qgc3RydWN0IHhzcGxpY2VfZWxmX3NlYyAqc2VjOwo+ ICAgICAgIHVuc2lnbmVkIGludCBpOwo+ICAgICAgIHN0cnVjdCB4c3BsaWNlX3BhdGNoX2Z1bmMg KmY7Cj4gKyAgICBzdHJ1Y3QgdmlydHVhbF9yZWdpb24gKnJlZ2lvbjsKPgo+ICAgICAgIHNlYyA9 IHhzcGxpY2VfZWxmX3NlY19ieV9uYW1lKGVsZiwgRUxGX1hTUExJQ0VfRlVOQyk7Cj4gICAgICAg QVNTRVJUKHNlYyk7Cj4gQEAgLTQyMiw2ICs0NzUsMTMgQEAgc3RhdGljIGludCBwcmVwYXJlX3Bh eWxvYWQoc3RydWN0IHBheWxvYWQgKnBheWxvYWQsCj4gICAgICAgICAgIH0KPiAgICAgICB9Cj4K PiArICAgIC8qIFNldHVwIHRoZSB2aXJ0dWFsIHJlZ2lvbiB3aXRoIHByb3BlciBkYXRhLiAqLwo+ ICsgICAgcmVnaW9uID0gJnBheWxvYWQtPnJlZ2lvbjsKPiArCj4gKyAgICByZWdpb24tPnN5bWJv bHNfbG9va3VwID0geHNwbGljZV9zeW1ib2xzX2xvb2t1cDsKPiArICAgIHJlZ2lvbi0+c3RhcnQg PSBwYXlsb2FkLT50ZXh0X2FkZHI7Cj4gKyAgICByZWdpb24tPmVuZCA9IHBheWxvYWQtPnRleHRf YWRkciArIHBheWxvYWQtPnRleHRfc2l6ZTsKClRoaXMgY2FsY3VsYXRpb24gaXMgd3JvbmcgZHVl IHRvIHRoZSB1c2Ugb2Ygdm9pZCAqLgoKLS0gClJvc3MgTGFnZXJ3YWxsCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0 Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=