From: "Jan Beulich" <JBeulich@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <JGross@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>,
David Vrabel <david.vrabel@citrix.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] xen-pciback: return proper values during BAR sizing
Date: Mon, 06 Jun 2016 07:51:57 -0600 [thread overview]
Message-ID: <57559C1D02000078000F20DF__46561.6495152519$1465221209$gmane$org@prv-mh.provo.novell.com> (raw)
In-Reply-To: <5755748D.6050900@oracle.com>
>>> On 06.06.16 at 15:03, <boris.ostrovsky@oracle.com> wrote:
> On 06/06/2016 04:11 AM, Jan Beulich wrote:
>> @@ -225,38 +225,42 @@ static inline void read_dev_bar(struct p
>> (PCI_BASE_ADDRESS_SPACE_MEMORY |
>> PCI_BASE_ADDRESS_MEM_TYPE_64))) {
>> bar_info->val = res[pos - 1].start >> 32;
>> - bar_info->len_val = res[pos - 1].end >> 32;
>> + bar_info->len_val = -resource_size(&res[pos - 1]) >> 32;
>> return;
>> }
>> }
>>
>> + if (!res[pos].flags ||
>> + (res[pos].flags & (IORESOURCE_DISABLED | IORESOURCE_UNSET |
>> + IORESOURCE_BUSY)))
>> + return;
>
> Why are you not making this check first thing in the routine?
For one, pos isn't set there yet. And I'd also rather avoid the
complications resulting from 64-bit memory resources spanning
two entries.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-06 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <57554B8D02000078000F1DE4@prv-mh.provo.novell.com>
2016-06-06 8:11 ` [PATCH 1/2] xen-pciback: return proper values during BAR sizing Jan Beulich
2016-06-06 8:12 ` [PATCH 2/2] xen-pciback: clean up read_dev_bar() Jan Beulich
2016-06-06 8:47 ` [PATCH 3/2] xen-pciback: drop rom_init() Jan Beulich
[not found] ` <57554C5D02000078000F1DF1@prv-mh.provo.novell.com>
2016-06-06 13:03 ` [PATCH 1/2] xen-pciback: return proper values during BAR sizing Boris Ostrovsky
2016-06-06 13:51 ` Jan Beulich [this message]
[not found] ` <57559C1D02000078000F20DF@prv-mh.provo.novell.com>
2016-06-06 14:28 ` Boris Ostrovsky
[not found] ` <57554C7502000078000F1DF5@prv-mh.provo.novell.com>
2016-06-06 13:04 ` [PATCH 2/2] xen-pciback: clean up read_dev_bar() Boris Ostrovsky
[not found] ` <575554CC02000078000F1E3F@prv-mh.provo.novell.com>
2016-06-06 13:09 ` [PATCH 3/2] xen-pciback: drop rom_init() Boris Ostrovsky
2016-06-06 13:54 ` Jan Beulich
[not found] ` <57559CBD02000078000F20EC@prv-mh.provo.novell.com>
2016-06-06 14:35 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='57559C1D02000078000F20DF__46561.6495152519$1465221209$gmane$org@prv-mh.provo.novell.com' \
--to=jbeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).