From: "Jan Beulich" <JBeulich@suse.com>
To: Quan Xu <quan.xu@intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
dario.faggioli@citrix.com, xen-devel@lists.xen.org,
Jun Nakajima <jun.nakajima@intel.com>
Subject: Re: [PATCH v7 02/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping
Date: Wed, 08 Jun 2016 08:40:51 -0600 [thread overview]
Message-ID: <57584A9302000078000F3276@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1465376344-28290-3-git-send-email-quan.xu@intel.com>
>>> On 08.06.16 at 10:58, <quan.xu@intel.com> wrote:
> @@ -831,10 +837,24 @@ out:
> {
> if ( iommu_flags )
> for ( i = 0; i < (1 << order); i++ )
> - iommu_map_page(d, gfn + i, mfn_x(mfn) + i, iommu_flags);
> + {
> + rc = iommu_map_page(d, gfn + i, mfn_x(mfn) + i, iommu_flags);
> + if ( unlikely(rc) )
> + {
> + while ( i-- )
> + if ( iommu_unmap_page(p2m->domain, gfn + i) )
> + continue;
Nice idea. I would have preferred a brief comment explaining this,
but anyway.
> @@ -140,8 +142,17 @@ void __hwdom_init vtd_set_hwdom_mapping(struct domain *d)
>
> tmp = 1 << (PAGE_SHIFT - PAGE_SHIFT_4K);
> for ( j = 0; j < tmp; j++ )
> - iommu_map_page(d, pfn * tmp + j, pfn * tmp + j,
> - IOMMUF_readable|IOMMUF_writable);
> + {
> + int ret = iommu_map_page(d, pfn * tmp + j, pfn * tmp + j,
> + IOMMUF_readable|IOMMUF_writable);
> +
> + if( !rc )
Missing blank (could be fixed upon commit if no other reason for
another iteration arises).
Reviewed-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-08 14:40 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 8:58 [PATCH v7 00/11] Check VT-d Device-TLB flush error Xu, Quan
2016-06-08 8:58 ` [PATCH v7 01/11] IOMMU: handle IOMMU mapping and unmapping failures Xu, Quan
2016-06-08 8:58 ` [PATCH v7 02/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping Xu, Quan
2016-06-08 14:40 ` Jan Beulich [this message]
[not found] ` <57584D8602000078000F32D0@prv-mh.provo.novell.com>
[not found] ` <421857ad-4f6b-e99c-1e81-034b19effdfb@amd.com>
2016-06-10 6:56 ` Jan Beulich
2016-06-12 6:41 ` Tian, Kevin
2016-06-08 8:58 ` [PATCH v7 03/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU unmapping (top level ones) Xu, Quan
2016-06-08 14:42 ` Jan Beulich
2016-06-08 14:54 ` Jan Beulich
2016-06-09 19:30 ` Suravee Suthikulanit
2016-06-09 10:28 ` Julien Grall
2016-06-08 8:58 ` [PATCH v7 04/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU mapping " Xu, Quan
2016-06-08 14:43 ` Jan Beulich
2016-06-09 18:45 ` Suravee Suthikulanit
2016-06-09 10:30 ` Julien Grall
2016-06-08 8:58 ` [PATCH v7 05/11] IOMMU/MMU: propagate IOMMU Device-TLB flush error up to iommu_iotlb_flush{, _all} " Xu, Quan
2016-06-09 11:12 ` Julien Grall
2016-06-09 11:45 ` Jan Beulich
2016-06-09 12:03 ` Julien Grall
2016-06-09 12:08 ` Julien Grall
2016-06-09 12:15 ` Jan Beulich
2016-06-09 12:24 ` Julien Grall
2016-06-09 12:32 ` Jan Beulich
2016-06-09 12:39 ` Julien Grall
2016-06-12 6:55 ` Tian, Kevin
2016-06-12 7:02 ` Xu, Quan
2016-06-12 15:35 ` Julien Grall
2016-06-09 12:14 ` Jan Beulich
2016-06-12 6:46 ` Tian, Kevin
2016-06-08 8:58 ` [PATCH v7 06/11] propagate IOMMU Device-TLB flush error up to EPT update " Xu, Quan
2016-06-08 8:59 ` [PATCH v7 07/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending " Xu, Quan
2016-06-08 14:51 ` Jan Beulich
2016-06-12 7:42 ` Xu, Quan
2016-06-13 9:25 ` Jan Beulich
2016-06-09 18:58 ` Suravee Suthikulanit
2016-06-12 6:58 ` Tian, Kevin
2016-06-08 8:59 ` [PATCH v7 08/11] IOMMU: propagate IOMMU Device-TLB flush error (leaf ones) Xu, Quan
2016-06-08 8:59 ` [PATCH v7 09/11] vt-d: fix the IOMMU flush issue Xu, Quan
2016-06-12 7:32 ` Tian, Kevin
2016-06-12 9:27 ` Xu, Quan
2016-06-13 8:50 ` Xu, Quan
2016-06-08 8:59 ` [PATCH v7 10/11] vt-d: propagate the IOMMU Device-TLB flush error up to ME phantom functions Xu, Quan
2016-06-12 7:34 ` Tian, Kevin
2016-06-08 8:59 ` [PATCH v7 11/11] vt-d: add __must_check annotation to IOMMU flush pointers and handlers Xu, Quan
2016-06-12 7:35 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57584A9302000078000F3276@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=quan.xu@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).