From: Julien Grall <julien.grall@arm.com>
To: Shanker Donthineni <shankerd@codeaurora.org>,
xen-devel <xen-devel@lists.xensource.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Andre Przywara <andre.przywara@arm.com>,
Philip Elcan <pelcan@codeaurora.org>,
Vikram Sethi <vikrams@codeaurora.org>,
Wei Chen <wei.chen@linaro.org>
Subject: Re: [PATCH V8 2/3] drivers/pl011: Use combination of UARTRIS and UARTMSC instead of UARTMIS
Date: Thu, 9 Jun 2016 11:15:59 +0100 [thread overview]
Message-ID: <575941DF.4010001@arm.com> (raw)
In-Reply-To: <1465392516-20542-2-git-send-email-shankerd@codeaurora.org>
Hello Shanker,
On 08/06/16 14:28, Shanker Donthineni wrote:
> The Masked interrupt status register (UARTMIS) is not described in ARM
> SBSA 2.x document. Anding of two registers UARTMSC and UARTRIS values
> gives the same information as register UARTMIS.
>
> UARTRIS, UARTMSC and UARTMIS definitions are found in PrimeCell UART
> PL011 (Revision: r1p4).
> - 3.3.10 Interrupt mask set/clear register, UARTIMSC
> - 3.3.11 Raw interrupt status register, UARTRIS
> - 3.3.12 Masked interrupt status register, UARTMIS
>
> This change is necessary for driver to be SBSA compliant v2.x without
> affecting the current driver functionality.
>
> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
> ---
> Changes since v7:
> Moved comment 'To compatible with SBSA v2.x document, all accesses should be 32-bit' to #3
>
> Changes since v1:
> Added a new function to return an interrupt status.
>
> xen/drivers/char/pl011.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c
> index 6a3c21b..a2f929b 100644
> --- a/xen/drivers/char/pl011.c
> +++ b/xen/drivers/char/pl011.c
> @@ -53,11 +53,17 @@ static struct pl011 {
> #define pl011_read(uart, off) readl((uart)->regs + (off))
> #define pl011_write(uart, off,val) writel((val), (uart)->regs + (off))
>
> +static unsigned int pl011_intr_status(struct pl011 *uart)
> +{
> + /* UARTMIS is not documented in SBSA v2.x, so using UARTRIS/UARTIMSC */
s/so using/so use/
Also missing full stop at the end of the comment.
> + return ( pl011_read(uart, RIS) & pl011_read(uart, IMSC) );
No space after the first parenthesis and before the last one.
With these changes:
Reviewed-by: Julien Grall <julien.grall@arm.com>
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-09 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 13:28 [PATCH V8 1/3] drivers/pl011: Don't configure baudrate Shanker Donthineni
2016-06-08 13:28 ` [PATCH V8 2/3] drivers/pl011: Use combination of UARTRIS and UARTMSC instead of UARTMIS Shanker Donthineni
2016-06-09 10:15 ` Julien Grall [this message]
2016-06-09 15:27 ` Shanker Donthineni
2016-06-08 13:28 ` [PATCH V8 3/3] arm/acpi: Add Server Base System Architecture UART support Shanker Donthineni
2016-06-09 10:19 ` Julien Grall
2016-06-09 15:26 ` Shanker Donthineni
2016-06-09 15:35 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575941DF.4010001@arm.com \
--to=julien.grall@arm.com \
--cc=andre.przywara@arm.com \
--cc=pelcan@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=vikrams@codeaurora.org \
--cc=wei.chen@linaro.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).