From: "Jan Beulich" <JBeulich@suse.com>
To: "Julien Grall" <julien.grall@arm.com>,
"Stefano Stabellini" <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <stefanos@xilinx.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH v4 1/2] xen: switch pdx_init_mask to return uint64_t
Date: Fri, 21 Jun 2019 00:17:38 -0600 [thread overview]
Message-ID: <5D0C76820200007800239ED2@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <956b7e98-ab75-0496-473d-08a59f719e62@arm.com>
>>> On 20.06.19 at 15:15, <julien.grall@arm.com> wrote:
> On 6/18/19 11:23 AM, Jan Beulich wrote:
>>>>> On 17.06.19 at 20:50, <sstabellini@kernel.org> wrote:
>>> Also change srat_region_mask to uint64_t as it is used to store the
>>> return value of pdx_init_mask. uint64_t is always greater or equal to
>>> u64.
>
> I am a bit confused with the last sentence. In which instance, uint64_t
> would be greater to u64? Aren't they meant to both encode a 64-bit value?
Oh, indeed - somehow I didn't even notice this. If anything it's the other
way around actually, because uint64_t is mandated to be exactly 64 bits
wide, whereas there's no strict specification for u64 afaia, but I very
much assume the intentions there have been the same.
The proposed title and text replacements look fine to me.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-21 6:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 18:50 [Xen-devel] [PATCH v4 0/2] fix mask calculation in pdx_init_mask Stefano Stabellini
2019-06-17 18:50 ` [Xen-devel] [PATCH v4 1/2] xen: switch pdx_init_mask to return uint64_t Stefano Stabellini
2019-06-18 10:23 ` Jan Beulich
2019-06-20 13:15 ` Julien Grall
2019-06-21 6:17 ` Jan Beulich [this message]
2019-06-17 18:50 ` [Xen-devel] [PATCH v4 2/2] xen/arm: fix mask calculation in pdx_init_mask Stefano Stabellini
2019-06-20 13:20 ` Julien Grall
2019-06-21 6:21 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D0C76820200007800239ED2@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=stefanos@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).