From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 4/6] x86/ucode: Rationalise startup and family/model checks
Date: Fri, 20 Mar 2020 14:37:07 +0100 [thread overview]
Message-ID: <5bc79b55-37c6-005f-2dd9-ac929d3627fb@suse.com> (raw)
In-Reply-To: <20200319152622.31758-5-andrew.cooper3@citrix.com>
On 19.03.2020 16:26, Andrew Cooper wrote:
> Drop microcode_init_{intel,amd}(), export {intel,amd}_ucode_ops, and use a
> switch statement in early_microcode_init() rather than probing each vendor in
> turn. This allows the microcode_ops pointer to become local to core.c.
>
> As there are no external users of microcode_ops, there is no need for
> collect_cpu_info() to implement sanity checks. Move applicable checks to
> early_microcode_init() so they are performed once, rather than repeatedly.
>
> Items to note:
> * The AMD ucode driver does have an upper familiy limit of 0x17, as a side
> effect of the logic in verify_patch_size() which does need updating for
> each new model.
I don't see this being the case, and hence I think it is this patch
which introduces such a restriction. As long a patches are less
than 2k, all unspecified families are supported by verify_patch_size()
through its default: case label. (Arguably the name F1XH_MPB_MAX_SIZE
doesn't really fit how it is being used.)
I'm happy about all other changes made here.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-03-20 13:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 15:26 [Xen-devel] [PATCH 0/6] x86/ucode: Cleanup - Part 1/n Andrew Cooper
2020-03-19 15:26 ` [Xen-devel] [PATCH 1/6] x86/ucode: Remove declarations for non-external functions Andrew Cooper
2020-03-19 15:26 ` [Xen-devel] [PATCH 2/6] x86/ucode: Move microcode into its own directory Andrew Cooper
2020-03-19 15:26 ` [Xen-devel] [PATCH 3/6] x86/ucode: Move interface from processor.h to microcode.h Andrew Cooper
2020-03-19 15:26 ` [Xen-devel] [PATCH 4/6] x86/ucode: Rationalise startup and family/model checks Andrew Cooper
2020-03-20 13:37 ` Jan Beulich [this message]
2020-03-20 13:40 ` Andrew Cooper
2020-03-20 13:56 ` Jan Beulich
2020-03-20 14:27 ` Andrew Cooper
2020-03-20 14:48 ` Jan Beulich
2020-03-19 15:26 ` [Xen-devel] [PATCH 5/6] x86/ucode: Alter ops->free_patch() to free the entire patch Andrew Cooper
2020-03-20 13:51 ` Jan Beulich
2020-03-20 14:50 ` Andrew Cooper
2020-03-20 15:15 ` Jan Beulich
2020-03-20 16:10 ` Andrew Cooper
2020-03-20 16:16 ` Jan Beulich
2020-03-20 16:48 ` Andrew Cooper
2020-03-23 7:52 ` Jan Beulich
2020-03-19 15:26 ` [Xen-devel] [PATCH 6/6] x86/ucode: Make struct microcode_patch opaque Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bc79b55-37c6-005f-2dd9-ac929d3627fb@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).