Hey, So... On Mon, 2021-05-17 at 19:16 +0100, Julien Grall wrote: > On 10/05/2021 09:35, Costin Lupu wrote: > > If PAGE_SIZE is already defined in the system (e.g. in > > /usr/include/limits.h > > header) then gcc will trigger a redefinition error because of - > > Werror. This > > patch replaces usage of PAGE_* macros with XC_PAGE_* macros in > > order to avoid > > confusion between control domain page granularity (PAGE_* > > definitions) and > > guest domain page granularity (which is what we are dealing with > > here). > > > > Same issue applies for redefinitions of Val_none and Some_val > > macros which > > can be already define in the OCaml system headers (e.g. > > /usr/lib/ocaml/caml/mlvalues.h). > > ... At least this part is absolutely necessary for building Xen on openSUSE Tumbleweed, therefore: > > Signed-off-by: Costin Lupu > > Reviewed-by: Julien Grall > Tested-by: Dario Faggioli Thanks and Regards -- Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere)