From: Paul Durrant <Paul.Durrant@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Xen-devel] [PATCH 1/3] xen / notify: introduce a new XenWatchList abstraction
Date: Thu, 12 Sep 2019 11:40:54 +0000 [thread overview]
Message-ID: <6af73152bb3e4028a4354a30006ad840@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <20190912101640.GB1308@perard.uk.xensource.com>
> -----Original Message-----
> From: Anthony PERARD <anthony.perard@citrix.com>
> Sent: 12 September 2019 11:17
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Stefano Stabellini <sstabellini@kernel.org>
> Subject: Re: [PATCH 1/3] xen / notify: introduce a new XenWatchList abstraction
>
> On Wed, Sep 11, 2019 at 03:36:16PM +0100, Paul Durrant wrote:
> > Xenstore watch call-backs are already abstracted away from XenBus using
> > the XenWatch data structure but the associated NotifierList manipulation
> > and file handle registation is still open coded in various xen_bus_...()
> ^ registration
Ok.
> > functions.
> > This patch creates a new XenWatchList data structure to allow these
> > interactions to be abstracted away from XenBus as well. This is in
> > preparation for a subsequent patch which will introduce separate watch lists
> > for XenBus and XenDevice objects.
> >
> > NOTE: This patch also introduces a new NotifierListEmpty() helper function
> ^ notifier_list_empty() ?
>
Oops, yes :-)
> > for the purposes of adding an assertion that a XenWatchList is not
> > freed whilst its associated NotifierList is still occupied.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
>
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
>
Thanks,
Paul
> --
> Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-12 11:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 14:36 [Xen-devel] [PATCH 0/3] xen: fix a potential crash in xen-bus Paul Durrant
2019-09-11 14:36 ` [Xen-devel] [PATCH 1/3] xen / notify: introduce a new XenWatchList abstraction Paul Durrant
2019-09-12 10:16 ` Anthony PERARD
2019-09-12 11:40 ` Paul Durrant [this message]
2019-09-11 14:36 ` [Xen-devel] [PATCH 2/3] xen: introduce separate XenWatchList for XenDevice objects Paul Durrant
2019-09-12 11:27 ` Anthony PERARD
2019-09-11 14:36 ` [Xen-devel] [PATCH 3/3] xen: perform XenDevice clean-up in XenBus watch handler Paul Durrant
2019-09-11 16:15 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6af73152bb3e4028a4354a30006ad840@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).