From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org,
Roger Pau Monne <roger.pau@citrix.com>,
paul@xen.org
Subject: Re: [PATCH] x86/viridian: EOI MSR should always happen in affected vCPU context
Date: Wed, 5 Jan 2022 08:46:34 +0100 [thread overview]
Message-ID: <74c658ec-cf69-5232-de66-929aea9f91f2@suse.com> (raw)
In-Reply-To: <910fcf36-a0c6-9f1e-a402-9afa6a5c4a1f@suse.com>
On 15.04.2021 11:57, Jan Beulich wrote:
> On 01.04.2021 12:50, Paul Durrant wrote:
>> On 01/04/2021 11:22, Roger Pau Monne wrote:
>>> The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU
>>> as current, as there's no support for EOI'ing interrupts on a remote
>>> vCPU.
>>>
>>> While there also turn the unconditional assert at the top of the
>>> function into an error on non-debug builds.
>>>
>>> No functional change intended.
>>>
>>> Requested-by: Jan Beulich <jbeulich@suse.com>
>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>
>> Reviewed-by: Paul Durrant <paul@xen.org>
>
> Andrew,
>
> can you please clarify whether your concern was addressed and this can
> go in as-is, or (if not) reply to what Roger and I have said in response?
This continues to be pending. I guess I'll consider ongoing silence as an
indication of your concerns having been addressed, committing the patch
perhaps early next week.
Jan
next prev parent reply other threads:[~2022-01-05 7:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 10:22 [PATCH] x86/viridian: EOI MSR should always happen in affected vCPU context Roger Pau Monne
2021-04-01 10:50 ` Paul Durrant
2021-04-15 9:57 ` Jan Beulich
2022-01-05 7:46 ` Jan Beulich [this message]
2021-04-01 10:55 ` Jan Beulich
2021-04-01 12:44 ` Andrew Cooper
2021-04-01 13:38 ` Jan Beulich
2021-04-01 14:41 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74c658ec-cf69-5232-de66-929aea9f91f2@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).