From: Julien Grall <julien.grall@arm.com>
To: Doug Goldstein <cardoe@cardoe.com>, xen-devel@lists.xen.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Daniel De Graaf <dgdegra@tycho.nsa.gov>,
Stefano Stabellini <sstabellini@kernel.org>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v5 3/6] build: convert verbose to Kconfig
Date: Thu, 26 May 2016 09:34:33 +0100 [thread overview]
Message-ID: <80656cf9-8e08-8279-112c-3ffec858dda7@arm.com> (raw)
In-Reply-To: <1464098199-19851-4-git-send-email-cardoe@cardoe.com>
Hi Doug,
On 24/05/2016 14:56, Doug Goldstein wrote:
> Convert 'verbose', which was enabled by 'debug=y' to Kconfig as
> CONFIG_VERBOSE_DEBUG which is enabled by default when CONFIG_DEBUG is
> enabled.
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Julien Grall <julien.grall@arm.com>
Regards,
> ---
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> ---
> INSTALL | 1 -
> xen/Kconfig.debug | 7 +++++++
> xen/Rules.mk | 6 +++---
> xen/arch/arm/kernel.c | 2 +-
> xen/arch/x86/domain_build.c | 2 +-
> xen/include/xsm/dummy.h | 2 +-
> 6 files changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/INSTALL b/INSTALL
> index 2974b9b..35668bd 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -227,7 +227,6 @@ VGABIOS_REL_DATE="dd Mon yyyy"
>
> The following variables can be used to tweak some aspects of the
> hypervisor build.
> -verbose=y
> perfc=y
> perfc_arrays=y
> lock_profile=y
> diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
> index 8eeb13f..fb11c56 100644
> --- a/xen/Kconfig.debug
> +++ b/xen/Kconfig.debug
> @@ -20,6 +20,13 @@ config CRASH_DEBUG
> If you want to attach gdb to Xen to debug Xen if it crashes
> then say Y.
>
> +config VERBOSE_DEBUG
> + bool "Verbose debug messages"
> + default DEBUG
> + ---help---
> + Guest output from HYPERVISOR_console_io and hypervisor parsing
> + ELF images (dom0) will be logged in the Xen ring buffer.
> +
> endif # DEBUG || EXPERT
>
> endmenu
> diff --git a/xen/Rules.mk b/xen/Rules.mk
> index b077e25..2a93ef7 100644
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -3,7 +3,6 @@
> # If you change any of these configuration options then you must
> # 'make clean' before rebuilding.
> #
> -verbose ?= n
> perfc ?= n
> perfc_arrays ?= n
> lock_profile ?= n
> @@ -17,7 +16,6 @@ include $(XEN_ROOT)/Config.mk
> # Hardcoded configuration implications and dependencies.
> # Do this is a neater way if it becomes unwieldy.
> ifeq ($(debug),y)
> -verbose := y
> frame_pointer := y
> endif
> ifeq ($(perfc_arrays),y)
> @@ -33,6 +31,9 @@ endif
> ifneq ($(origin kexec),undefined)
> $(error "You must use 'make menuconfig' to enable/disable kexec now.")
> endif
> +ifneq ($(origin verbose),undefined)
> +$(error "You must use 'make menuconfig' to enable/disable verbose now.")
> +endif
>
> # Set ARCH/SUBARCH appropriately.
> override TARGET_SUBARCH := $(XEN_TARGET_ARCH)
> @@ -60,7 +61,6 @@ ifneq ($(clang),y)
> CFLAGS += -Wa,--strip-local-absolute
> endif
>
> -CFLAGS-$(verbose) += -DVERBOSE
> CFLAGS-$(perfc) += -DPERF_COUNTERS
> CFLAGS-$(perfc_arrays) += -DPERF_ARRAYS
> CFLAGS-$(lock_profile) += -DLOCK_PROFILE
> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
> index 9871bd9..3f6cce3 100644
> --- a/xen/arch/arm/kernel.c
> +++ b/xen/arch/arm/kernel.c
> @@ -472,7 +472,7 @@ static int kernel_elf_probe(struct kernel_info *info,
>
> if ( (rc = elf_init(&info->elf.elf, info->elf.kernel_img, size )) != 0 )
> goto err;
> -#ifdef VERBOSE
> +#ifdef CONFIG_VERBOSE_DEBUG
> elf_set_verbose(&info->elf.elf);
> #endif
> elf_parse_binary(&info->elf.elf);
> diff --git a/xen/arch/x86/domain_build.c b/xen/arch/x86/domain_build.c
> index f9a3eca..b29c377 100644
> --- a/xen/arch/x86/domain_build.c
> +++ b/xen/arch/x86/domain_build.c
> @@ -942,7 +942,7 @@ int __init construct_dom0(
>
> if ( (rc = elf_init(&elf, image_start, image_len)) != 0 )
> return rc;
> -#ifdef VERBOSE
> +#ifdef CONFIG_VERBOSE_DEBUG
> elf_set_verbose(&elf);
> #endif
> elf_parse_binary(&elf);
> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
> index abbe282..406cd18 100644
> --- a/xen/include/xsm/dummy.h
> +++ b/xen/include/xsm/dummy.h
> @@ -215,7 +215,7 @@ static XSM_INLINE int xsm_memory_stat_reservation(XSM_DEFAULT_ARG struct domain
> static XSM_INLINE int xsm_console_io(XSM_DEFAULT_ARG struct domain *d, int cmd)
> {
> XSM_ASSERT_ACTION(XSM_OTHER);
> -#ifdef VERBOSE
> +#ifdef CONFIG_VERBOSE_DEBUG
> if ( cmd == CONSOLEIO_write )
> return xsm_default_action(XSM_HOOK, d, NULL);
> #endif
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-26 8:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 13:56 [PATCH v5 0/6] Kconfig debug options Doug Goldstein
2016-05-24 13:56 ` [PATCH v5 1/6] build: convert debug to Kconfig Doug Goldstein
2016-05-24 14:53 ` Jan Beulich
2016-06-08 16:53 ` Julien Grall
2016-06-08 17:34 ` Doug Goldstein
2016-05-24 13:56 ` [PATCH v5 2/6] build: convert crash_debug " Doug Goldstein
2016-05-24 13:56 ` [PATCH v5 3/6] build: convert verbose " Doug Goldstein
2016-05-26 8:34 ` Julien Grall [this message]
2016-05-26 13:36 ` Daniel De Graaf
2016-05-24 13:56 ` [PATCH v5 4/6] build: convert frame_pointer " Doug Goldstein
2016-05-24 13:56 ` [PATCH v5 5/6] build: convert perfc{, _arrays} " Doug Goldstein
2016-05-24 13:56 ` [PATCH v5 6/6] build: convert lock_profile " Doug Goldstein
2016-05-26 8:35 ` Julien Grall
2016-05-25 16:23 ` [PATCH v5 0/6] Kconfig debug options Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80656cf9-8e08-8279-112c-3ffec858dda7@arm.com \
--to=julien.grall@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).