From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B8C4C2D0A3 for ; Thu, 12 Nov 2020 11:55:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED2B5221FE for ; Thu, 12 Nov 2020 11:55:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="LUhTA6s7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED2B5221FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.25743.53707 (Exim 4.92) (envelope-from ) id 1kdBCT-0005Dq-Al; Thu, 12 Nov 2020 11:55:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 25743.53707; Thu, 12 Nov 2020 11:55:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kdBCT-0005Dj-7t; Thu, 12 Nov 2020 11:55:37 +0000 Received: by outflank-mailman (input) for mailman id 25743; Thu, 12 Nov 2020 11:55:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kdBCR-0005De-My for xen-devel@lists.xenproject.org; Thu, 12 Nov 2020 11:55:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b3a41be7-38b3-45f1-85c1-6dce4b1ca034; Thu, 12 Nov 2020 11:55:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E2CCCAEAA; Thu, 12 Nov 2020 11:55:32 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kdBCR-0005De-My for xen-devel@lists.xenproject.org; Thu, 12 Nov 2020 11:55:35 +0000 X-Inumbo-ID: b3a41be7-38b3-45f1-85c1-6dce4b1ca034 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b3a41be7-38b3-45f1-85c1-6dce4b1ca034; Thu, 12 Nov 2020 11:55:33 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1605182133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pdla3Ap0GWpOtbianQP0foKR4T1rYZELNePwWVVMuUE=; b=LUhTA6s76UzYJmayPPjgRmRP512fvJcISkJUB9/Sb0uYxbZix/rDZT1VPGAgz9SgcX7WxZ NgHP4yo9aADw0rsd2WmaAa9xmxsoVw7TzC1Iy6YqWQ+hWpRH2pxVYdFuT+LAPaSqZoUwZp c9HT0nwhCMsMHjMuscSWWiDnyYp2g7c= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E2CCCAEAA; Thu, 12 Nov 2020 11:55:32 +0000 (UTC) Subject: Re: [PATCH V2 20/23] xen/ioreq: Make x86's send_invalidate_req() common To: Oleksandr Tyshchenko Cc: Oleksandr Tyshchenko , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Paul Durrant , Julien Grall , xen-devel@lists.xenproject.org References: <1602780274-29141-1-git-send-email-olekstysh@gmail.com> <1602780274-29141-21-git-send-email-olekstysh@gmail.com> From: Jan Beulich Message-ID: <86ac139b-4dfd-fc45-ea77-3bd51acaea15@suse.com> Date: Thu, 12 Nov 2020 12:55:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: <1602780274-29141-21-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 15.10.2020 18:44, Oleksandr Tyshchenko wrote: > --- a/xen/include/asm-x86/hvm/io.h > +++ b/xen/include/asm-x86/hvm/io.h > @@ -97,7 +97,6 @@ bool relocate_portio_handler( > unsigned int size); > > void send_timeoffset_req(unsigned long timeoff); > -void send_invalidate_req(void); > bool handle_mmio_with_translation(unsigned long gla, unsigned long gpfn, > struct npfec); > bool handle_pio(uint16_t port, unsigned int size, int dir); > diff --git a/xen/include/xen/ioreq.h b/xen/include/xen/ioreq.h > index 0679fef..aad682f 100644 > --- a/xen/include/xen/ioreq.h > +++ b/xen/include/xen/ioreq.h > @@ -126,6 +126,7 @@ struct ioreq_server *select_ioreq_server(struct domain *d, > int send_ioreq(struct ioreq_server *s, ioreq_t *proto_p, > bool buffered); > unsigned int broadcast_ioreq(ioreq_t *p, bool buffered); > +void send_invalidate_ioreq(void); Again while renaming this function anyway could we see about giving it a suitable and consistent name? Maybe ioreq_request_mapcache_invalidate() or (to avoid the double "request") ioreq_signal_mapcache_invalidate()? Maybe even ioreq_server_...(). Jan