From: Thomas Gleixner <tglx@linutronix.de>
To: "Jürgen Groß" <jgross@suse.com>,
"Sergei Temerkhanov" <s.temerkhanov@gmail.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data
Date: Fri, 21 Aug 2020 22:07:17 +0200 [thread overview]
Message-ID: <871rjzsqyy.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <b2917f59-d101-659d-1704-8d2a294bb2a1@suse.com>
On Fri, Aug 21 2020 at 14:17, Jürgen Groß wrote:
> On 21.08.20 13:19, Sergei Temerkhanov wrote:
>>> Did you see any specific problem where handler_data is written by
>> another component?
>>
>> I've posted this series in the thread
>> https://lists.xenproject.org/archives/html/xen-devel/2020-08/msg00957.html
>> where the problem is caused exactly by that behavior
>>
>>> In case this is a real problem I don't think your approach will be accepted
>> Any comments/suggestions are welcome
>
> Not sure if the IRQ maintainers agree with me, but I would add
> a set_handler_data and get_handler_data function pointer to
> struct irq_chip. If those are set I'd call them for writing/reading
> handler_data instead doing it directly. Xen could then specify those
> and add a field to its own handler data struct for storing the data
> of the driver coming later.
>
> Xen would need another accessor function for its own primary data,
> of course.
>
> Adding the IRQ maintainer as he might have an opinion here. :-)
Without seeing the patches, and no I'm not going to grab them from a web
archive, I'd say they are wrong :)
Fiddling in irqchip is wrong to begin with.
int irq_set_handler_data(unsigned int irq, void *data);
static inline void *irq_get_handler_data(unsigned int irq)
static inline void *irq_data_get_irq_handler_data(struct irq_data *d)
are accessors to handler_data. Am I missing something?
Thanks,
tglx
next prev parent reply other threads:[~2020-08-21 20:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 22:09 Xen 4.14.0 is busted on Dell 300x IoT Gateways Roman Shaposhnik
2020-08-18 22:20 ` Andrew Cooper
2020-08-18 22:34 ` Roman Shaposhnik
2020-08-21 1:39 ` Stefano Stabellini
2020-08-21 7:15 ` [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data Sergey Temerkhanov
2020-08-21 7:15 ` [PATCH 1/2] Xen: Use a dedicated irq_info structure pointer Sergey Temerkhanov
2020-08-21 7:15 ` [PATCH 2/2] Xen: Rename irq_info structure Sergey Temerkhanov
2020-08-21 10:18 ` [PATCH 0/2] Xen: Use a dedicated pointer for IRQ data Jürgen Groß
2020-08-21 11:19 ` Sergei Temerkhanov
2020-08-21 12:17 ` Jürgen Groß
2020-08-21 20:07 ` Thomas Gleixner [this message]
2020-08-21 20:38 ` Sergei Temerkhanov
2020-08-22 0:16 ` Thomas Gleixner
2020-08-25 3:14 ` Stefano Stabellini
2020-08-25 8:58 ` Thomas Gleixner
2020-08-25 13:49 ` Jürgen Groß
2020-08-25 15:22 ` [PATCH] xen/events: Use chip data for storing per IRQ XEN data pointer, Thomas Gleixner
2020-08-25 15:43 ` [PATCH] xen/events: Use chip data for storing per IRQ XEN data pointer Jürgen Groß
2020-08-25 22:04 ` Roman Shaposhnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rjzsqyy.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=jgross@suse.com \
--cc=s.temerkhanov@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).