xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Julien Grall <julien.grall@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()
Date: Wed, 11 Sep 2019 17:33:41 +0000	[thread overview]
Message-ID: <87r24mg2kr.fsf@epam.com> (raw)
In-Reply-To: <20190911151942.28459-1-julien.grall@arm.com>


Julien Grall writes:

> One line in process_multiboot_node() is using hard tab rather than soft
> tab. So fix it!
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

So, hunting them one-by-one is the preferred way? I'm asking this
because there are more of them:

% find xen/arch/arm -type f -name "*.[ch]" -exec grep -lP "\t" {} \;
xen/arch/arm/traps.c
xen/arch/arm/acpi/boot.c
xen/arch/arm/arm32/lib/assembler.h
xen/arch/arm/arm64/livepatch.c
xen/arch/arm/arm64/lib/find_next_bit.c
xen/arch/arm/arm64/insn.c
xen/arch/arm/alternative.c
xen/arch/arm/bootfdt.c (apparently, I don't have this patch applied)


> ---
>  xen/arch/arm/bootfdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index 258b057f00..623173bc7f 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -264,7 +264,7 @@ static void __init process_multiboot_node(const void *fdt, int node,
>          case 1: kind = BOOTMOD_RAMDISK; break;
>          default: break;
>          }
> -	if ( kind_guess > 1 && has_xsm_magic(start) )
> +        if ( kind_guess > 1 && has_xsm_magic(start) )
>              kind = BOOTMOD_XSM;
>      }


-- 
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-09-11 17:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 15:19 [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node() Julien Grall
2019-09-11 17:33 ` Volodymyr Babchuk [this message]
2019-09-11 17:58   ` Julien Grall
2019-09-12 17:06   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r24mg2kr.fsf@epam.com \
    --to=volodymyr_babchuk@epam.com \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).