From: "Xu, Quan" <quan.xu@intel.com>
To: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
"Wu, Feng" <feng.wu@intel.com>, Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Keir Fraser <keir@xen.org>
Subject: Re: [PATCH v4 0/2] Make the pcidevs_lock a recursive one
Date: Wed, 16 Mar 2016 02:39:07 +0000 [thread overview]
Message-ID: <945CA011AD5F084CBEA3E851C0AB28894B864D7E@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1457619007-41460-1-git-send-email-quan.xu@intel.com>
Hi,
__iiuc__, this patch set is ready for staging branch. if yes, could you help me merge it into staging branch?
Then, I would send out remaining patch sets on it. otherwise, there are some conflicts to it. Thanks.
Quan
On March 10, 2016 10:10pm, <quan.xu@Intel.com> wrote:
> This patch set makes the pcidevs_lock a recursive one, as pcidevs_lock is going
> to be recursively taken for hiding ATS device, when VT-d Device-TLB flush timed
> out. It is a prereq patch set for Patch:'VT-d Device-TLB flush issue'.
>
> In detail:
> 1. Fix a bug found in AMD IOMMU initialization
>
> pcidevs_lock doesn't require interrupts to be disabled while being acquired.
> However there remains an exception in AMD IOMMU code, where the lock is
> acquired with interrupt disabled. This inconsistency might lead to deadlock.
>
> The fix is straightforward to use spin_lock instead. Also interrupt has been
> enabled when this function is invoked, so we're sure consistency around
> pcidevs_lock can be guaranteed after this fix.
>
> 2. Make the pcidevs_lock a recursive one.
>
> pcidevs_lock is going to be recursively taken for hiding ATS device,
> when VT-d Device-TLB flush timed out.
>
>
>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> CC: Feng Wu <feng.wu@intel.com>
> CC: Kevin Tian <kevin.tian@intel.com>
> CC: Dario Faggioli <dario.faggioli@citrix.com>
>
> --Changes in v4:
> * Enhance changelogs.
> * Rebase against 0aa1330aac92.
>
> Quan Xu (2):
> IOMMU/spinlock: Fix a bug found in AMD IOMMU initialization
> IOMMU/spinlock: Make the pcidevs_lock a recursive one.
>
> xen/arch/x86/domctl.c | 8 +--
> xen/arch/x86/hvm/vmsi.c | 4 +-
> xen/arch/x86/irq.c | 8 +--
> xen/arch/x86/msi.c | 16 ++---
> xen/arch/x86/pci.c | 4 +-
> xen/arch/x86/physdev.c | 16 ++---
> xen/common/sysctl.c | 4 +-
> xen/drivers/passthrough/amd/iommu_init.c | 9 ++-
> xen/drivers/passthrough/amd/iommu_map.c | 2 +-
> xen/drivers/passthrough/amd/pci_amd_iommu.c | 4 +-
> xen/drivers/passthrough/pci.c | 97
> ++++++++++++++++++-----------
> xen/drivers/passthrough/vtd/intremap.c | 2 +-
> xen/drivers/passthrough/vtd/iommu.c | 14 ++---
> xen/drivers/video/vga.c | 4 +-
> xen/include/xen/pci.h | 5 +-
> 15 files changed, 110 insertions(+), 87 deletions(-)
>
> --
> 1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-16 2:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 14:10 [PATCH v4 0/2] Make the pcidevs_lock a recursive one Quan Xu
2016-03-10 14:10 ` [PATCH v4 1/2] IOMMU/spinlock: Fix a bug found in AMD IOMMU initialization Quan Xu
2016-03-11 0:24 ` Tian, Kevin
2016-03-11 1:40 ` Xu, Quan
2016-03-10 14:10 ` [PATCH v4 2/2] IOMMU/spinlock: Make the pcidevs_lock a recursive one Quan Xu
2016-03-10 14:32 ` Jan Beulich
2016-03-10 14:38 ` Dario Faggioli
2016-03-11 1:38 ` Xu, Quan
2016-03-11 1:33 ` Xu, Quan
2016-03-16 2:39 ` Xu, Quan [this message]
2016-03-16 8:39 ` [PATCH v4 0/2] " Dario Faggioli
2016-03-16 10:45 ` Jan Beulich
2016-03-17 1:39 ` Xu, Quan
2016-03-17 2:07 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=945CA011AD5F084CBEA3E851C0AB28894B864D7E@SHSMSX101.ccr.corp.intel.com \
--to=quan.xu@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).